Page MenuHome

Cleanup: Move mesh.c to C++
ClosedPublic

Authored by Erik Abrahamsson (erik85) on Nov 6 2021, 10:05 AM.

Details

Summary

Can be useful to be able to use C++ functionality for new functions.

Diff Detail

Repository
rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Nov 6 2021, 10:05 AM
Erik Abrahamsson (erik85) created this revision.

Only two clang tidy warnings:

/home/hans/Blender-Git/blender/source/blender/blenkernel/intern/mesh.cc:1969:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef struct SplitFaceNewVert {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/hans/Blender-Git/blender/source/blender/blenkernel/intern/mesh.cc:1976:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef struct SplitFaceNewEdge {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

They can be changed to struct SplitFaceNewVert { ... };

This revision is now accepted and ready to land.Nov 6 2021, 6:42 PM
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added inline comments.
source/blender/blenkernel/intern/mesh.cc
356–377

In the future, please keep named fields info, even though cpp does not support it in its syntax, as done in all other cpp ID files, using comments: /* id_code */ ID_ME,, etc.

This info is critical, especially for nullptr members, and to also quickly see where to add new entries, or if some are missing, etc.

source/blender/blenkernel/intern/mesh.cc
356–377

Sure, will do, sorry about that.