Can be useful to be able to use C++ functionality for new functions.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Kicked the bots to rule out any build issues : https://builder.blender.org/admin/#/builders/18/builds/161
Comment Actions
Only two clang tidy warnings:
/home/hans/Blender-Git/blender/source/blender/blenkernel/intern/mesh.cc:1969:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef struct SplitFaceNewVert {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/hans/Blender-Git/blender/source/blender/blenkernel/intern/mesh.cc:1976:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef struct SplitFaceNewEdge {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~They can be changed to struct SplitFaceNewVert { ... };
| source/blender/blenkernel/intern/mesh.cc | ||
|---|---|---|
| 356–377 | In the future, please keep named fields info, even though cpp does not support it in its syntax, as done in all other cpp ID files, using comments: /* id_code */ ID_ME,, etc. This info is critical, especially for nullptr members, and to also quickly see where to add new entries, or if some are missing, etc. | |
| source/blender/blenkernel/intern/mesh.cc | ||
|---|---|---|
| 356–377 | Sure, will do, sorry about that. | |