Page MenuHome
Differential D13139

Fix tracking-camera presets
ClosedPublic
Actions

Authored by Fynn Grotehans (TheFynn) on Nov 8 2021, 1:47 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T92559: Selecting Camera presets in Tracking layout gives 'Context' object has no attribute 'camera' error
Commits
rB486d1e85102f: Fix T92559: Tracking camera presets don't work
Summary

Fixing T92559
new tracking-camera presets d486ee2dbdd3 used wrong code because I copied them from the camera-presets. Now they set the right properties again, the values stay the same as before

Diff Detail

Repository
rB Blender

Event Timeline

Fynn Grotehans (TheFynn) requested review of this revision.Nov 8 2021, 1:47 AM
Fynn Grotehans (TheFynn) created this revision.
Fynn Grotehans (TheFynn) added a task: T92559: Selecting Camera presets in Tracking layout gives 'Context' object has no attribute 'camera' error.
Thomas Dinges (dingto) added a reviewer: Sergey Sharybin (sergey).Nov 8 2021, 12:43 PM
Thomas Dinges (dingto) added a subscriber: Thomas Dinges (dingto).

Change looks good to me, but I'll leave the final call to Sergey :)

Sergey Sharybin (sergey) added a comment.Nov 8 2021, 12:47 PM

Generally fine. Can you restore the newlines at the end of files?

Fynn Grotehans (TheFynn) updated this revision to Diff 44507.Nov 8 2021, 10:47 PM

New lines at end of files should be back now

Sergey Sharybin (sergey) accepted this revision.Nov 9 2021, 10:06 AM
This revision is now accepted and ready to land.Nov 9 2021, 10:06 AM
Closed by commit rB486d1e85102f: Fix T92559: Tracking camera presets don't work (authored by Fynn Grotehans (TheFynn), committed by Sergey Sharybin (sergey)). · Explain WhyNov 9 2021, 10:07 AM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rB486d1e85102f: Fix T92559: Tracking camera presets don't work.

Revision Contents
Changeset List

Diff 44480

View Options

release/scripts/presets/tracking_camera/1_inch.py

Loading...
View Options

release/scripts/presets/tracking_camera/1_slash_1.8_inch.py

Loading...
View Options

release/scripts/presets/tracking_camera/1_slash_2.3_inch.py

Loading...
View Options

release/scripts/presets/tracking_camera/1_slash_2.5_inch.py

Loading...
View Options

release/scripts/presets/tracking_camera/1_slash_2.7_inch.py

Loading...
View Options

release/scripts/presets/tracking_camera/1_slash_3.2_inch.py

Loading...
View Options

release/scripts/presets/tracking_camera/2_slash_3_inch.py

Loading...
View Options

release/scripts/presets/tracking_camera/APS-C.py

Loading...
View Options

release/scripts/presets/tracking_camera/APS-C_(Canon).py

Loading...
View Options

release/scripts/presets/tracking_camera/APS-H_(Canon).py

Loading...
View Options

release/scripts/presets/tracking_camera/Analog_16mm.py

Loading...
View Options

release/scripts/presets/tracking_camera/Analog_35mm.py

Loading...
View Options

release/scripts/presets/tracking_camera/Analog_65mm.py

Loading...
View Options

release/scripts/presets/tracking_camera/Analog_IMAX.py

Loading...
View Options

release/scripts/presets/tracking_camera/Analog_Super_16.py

Loading...
View Options

release/scripts/presets/tracking_camera/Analog_Super_35.py

Loading...
View Options

release/scripts/presets/tracking_camera/Arri_Alexa_65.py

Loading...
View Options

release/scripts/presets/tracking_camera/Arri_Alexa_LF.py

Loading...
View Options

release/scripts/presets/tracking_camera/Arri_Alexa_Mini_&_SXT.py

Loading...
View Options

release/scripts/presets/tracking_camera/Blackmagic_Pocket_&_Studio.py

Loading...
View Options

release/scripts/presets/tracking_camera/Blackmagic_Pocket_4K.py

Loading...
View Options

release/scripts/presets/tracking_camera/Blackmagic_Pocket_6k.py

Loading...
View Options

release/scripts/presets/tracking_camera/Blackmagic_URSA_4.6K.py

Loading...
View Options

release/scripts/presets/tracking_camera/Foveon_(Sigma).py

Loading...
View Options

release/scripts/presets/tracking_camera/Fullframe.py

Loading...
View Options

release/scripts/presets/tracking_camera/MFT.py

Loading...
View Options

release/scripts/presets/tracking_camera/Medium-format_(Hasselblad).py

Loading...
View Options

release/scripts/presets/tracking_camera/RED_Dragon_5K.py

Loading...
View Options

release/scripts/presets/tracking_camera/RED_Dragon_6K.py

Loading...
View Options

release/scripts/presets/tracking_camera/RED_Helium_8K.py

Loading...
View Options

release/scripts/presets/tracking_camera/RED_Monstro_8K.py

Loading...