Page MenuHome
Differential D13141

Fix: Add tooltip translation marker to disabled hints
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Nov 8 2021, 6:46 AM.

Details

Reviewers
Julian Eisel (Severin)
Commits
rBca9cdba2df82: Fix: Add tooltip translation marker to disabled hints
Summary

I think this was overlooked, as it seems there's no way for these
strings to be translated currently.

Diff Detail

Repository
rB Blender
Branch
fix-disabled-hint-tip (branched from master)
Build Status
Buildable 18533
Build 18533: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 8 2021, 6:46 AM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B18533: Diff 44484.Nov 8 2021, 6:46 AM
Julian Eisel (Severin) accepted this revision.Nov 19 2021, 7:29 PM

Makes sense to me. Was wondering if the caller should do the translation and we only use the N_() marker here, but I think this is more correct since from what I heard we differentiate by "what it represents" not "where is it shown" (tooltip or not). I personally don't agree with that but better stick to the existing conventions/design.
(There are still more cases where the disabled hint needs translating BTW.)

This revision is now accepted and ready to land.Nov 19 2021, 7:29 PM
Closed by commit rBca9cdba2df82: Fix: Add tooltip translation marker to disabled hints (authored by Hans Goudey (HooglyBoogly)). · Explain WhyDec 2 2021, 3:55 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBca9cdba2df82: Fix: Add tooltip translation marker to disabled hints.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_file/
2 lines
nodes/
composite/
2 lines
nodes/
4 lines
4 lines
function/
2 lines
geometry/
2 lines
intern/
2 lines
shader/
4 lines
texture/
2 lines

Diff 44484

View Options

source/blender/editors/space_file/asset_catalog_tree_view.cc

Loading...
View Options

source/blender/nodes/composite/node_composite_util.cc

Loading...
View Options

source/blender/nodes/composite/nodes/node_composite_cryptomatte.cc

Loading...
View Options

source/blender/nodes/composite/nodes/node_composite_image.cc

Loading...
View Options

source/blender/nodes/function/node_function_util.cc

Loading...
View Options

source/blender/nodes/geometry/node_geometry_util.cc

Loading...
View Options

source/blender/nodes/intern/node_common.cc

Loading...
View Options

source/blender/nodes/shader/node_shader_util.c

Loading...
View Options

source/blender/nodes/texture/node_texture_util.c

Loading...