Differential D13151

Remove error prone mixed sequencer/preview display type
Needs ReviewPublic
Actions

Authored by Campbell Barton (campbellbarton) on Nov 9 2021, 4:37 AM.

Details

Reviewers

Richard Antalik (ISS)

Maniphest Tasks

T92584: Mixing sequencer and preview regions causes logical problems

Summary

This removes mixes sequencer/preview display type.

Now preview supports editing operations it's impractical to support
displaying both at once as it complicates displaying actions in menus for e.g. which could apply
to both region types (select all, delete ... etc). See T92584 for details.

Existing files will set the view to show the sequence editor only.

NOTE: this patch should be applied after D13165: VSE: Move strip properties to property editor, to address the issue of insufficient vertical space for strip properties.

Diff Detail

Repository

rB Blender

Branch

TEMP-REMOVE-SEQ-PREVIEW (branched from master)

Build Status

Buildable 18552
Build 18552: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Nov 9 2021, 4:37 AM

Campbell Barton (campbellbarton) created this revision.

Harbormaster completed remote builds in B18552: Diff 44518.Nov 9 2021, 4:37 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Nov 9 2021, 4:42 AM

Campbell Barton (campbellbarton) added a reviewer: Richard Antalik (ISS).

Campbell Barton (campbellbarton) added a project: Video Sequencer.

Campbell Barton (campbellbarton) added a task: T92584: Mixing sequencer and preview regions causes logical problems.Nov 9 2021, 4:45 AM

Peter Fog (tintwotin) awarded a token.Nov 9 2021, 8:15 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Nov 12 2021, 5:40 AM

Campbell Barton (campbellbarton) added a project: BF Blender (3.1).

I have tested the patch, it doesn't remove one of preview or timeline regions, so both are still visible - is that intended? Looking at area split code is splitting possible in versioning code? Or does it have to be more manual? I was wondering if I wanted to change default layout if this should be done via code or by replacing startup.blend file itself...

I don't see anything wrong with code itself though