Differential D13162

Fix T92908: Print warning when instance recursion limit is reached.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 9 2021, 4:34 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T92908: Geometry Nodes: Cycles Ignores part of the geometry after Join Geometry node

Commits

rB4f246b8bf956: Fix T92908: print warning when instance recursion limit is reached

Summary

Currently we have a fixed instance recursion limit. While we want to lift this limitation at some point, that is out of scope for a bug fix. For now just print a warning to make it easier to detect the issue.

Diff Detail

Repository

rB Blender

Branch

instance-limit-warning (branched from master)

Build Status

Buildable 18563
Build 18563: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 9 2021, 4:34 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B18563: Diff 44549.Nov 9 2021, 4:34 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 9 2021, 4:36 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

Jacques Lucke (JacquesLucke) added a task: T92908: Geometry Nodes: Cycles Ignores part of the geometry after Join Geometry node.

Jacques Lucke (JacquesLucke) mentioned this in T92908: Geometry Nodes: Cycles Ignores part of the geometry after Join Geometry node.

How involved do you think it would be to add a warning to the instance on points node? That would be a more user-friendly place to expose the limit anyway.

It could work in some cases but not in general currently. That is because the Instance on Points node does (and should not) have to iterate through all the referenced objects/collections, ... Note that we are also talking about particle system instances here etc.

Ah, right, because the instance geometry can have multiple levels of instances as well.

This revision is now accepted and ready to land.Nov 9 2021, 5:32 PM

Closed by commit rB4f246b8bf956: Fix T92908: print warning when instance recursion limit is reached (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 9 2021, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB4f246b8bf956: Fix T92908: print warning when instance recursion limit is reached.