Page MenuHome

Cleanup of make.bat for Windows systems
ClosedPublic

Authored by Nikhil Shringarpurey (Nikhil.Net) on Nov 10 2021, 7:22 AM.

Details

Summary

The make.bat had several issues that needed fixing:

  1. Bad use of parenthesis on one line "(default)" changed to "[default]". This caused a syntax error when trying to run make help. The error was " to was unexpected at this time."
  2. Incorrect style use of echo. On Windows, the command echo. should be used to generate a blank line. A period should never be placed after echo for any other text on a line. This is considered bad syntax on Windows and may fail unpredictably.
  3. Incorrect use of UN*X style forward slashes. On WIndows, paths should use proper backslash syntax.
  4. The "LOCALE_MISSING" section was itself missing from the batch file. Added it and provided a link to the documentation page specifying how to install locales.
  5. Added quotes around all pathspecs to allow for directories with spaces in the name.

I tested these changes and they do not break functions, and restore proper use of make help. I'm guessing this has been broken for a LONG time.

Diff Detail

Repository
rBM Blender Manual

Event Timeline

Nikhil Shringarpurey (Nikhil.Net) created this revision.
  1. Added missing section LOCALE_MISSING in batch file with a link to the correct page specifying how to checkout translation repositories.
  2. Confirmed that make report_po_progress and make update_po work when locales are properly checked out as per point 1, above.

While I'm at it, I should probably add more help to the "report_po_progress" command, as there is the option to pass in a specific locale argument (make report_po_progress fr).

Nikhil Shringarpurey (Nikhil.Net) edited the summary of this revision. (Show Details)

Added quotes around all pathspecs to allow for directories with spaces in the name.

Tested all commands with nested folders with weird characters in them and they work.

Fixed bug added by last update with parentheses.

Approve of all changes, I see nothing that concerns me, however I currently do not have a manual build setup, so if you could give it a quick shake before landing @Aaron Carlisle (Blendify) that be appreciated.

This revision is now accepted and ready to land.Nov 10 2021, 6:01 PM

Hi committed to the 3.0 branch and this change is also now in Trunk as of rBM8634