Page MenuHome
Differential D13173

Fix T92979: Emission Strength Animation read wrong in 3.0
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 10 2021, 9:32 AM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Brecht Van Lommel (brecht)
Maniphest Tasks
T92979: keys on shader attributes get disconnected each time a Blender scene is closed.
Commits
rBaa2f6e597708: Fix T92979: Emission Strength Animation read wrong in 3.0
Summary

First this was wrong for files written in 2.93 read into blender in 3.0
after the CyclesX merge.
Then this was fixed by versioning in rB6321dd3d4007.
But this caused files written in 3.0 to have this versioning applied as well
(leading to socket shifting).

Now only do the versioning only for files created before the CyclesX
merge.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 10 2021, 9:32 AM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B18574: Diff 44571.Nov 10 2021, 9:32 AM
Philipp Oeser (lichtwerk) added projects: Render & Cycles, Animation & Rigging.Nov 10 2021, 9:32 AM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Nov 10 2021, 9:41 AM
William Leeson (leesonw) added a subscriber: William Leeson (leesonw).Nov 10 2021, 9:46 AM
Brecht Van Lommel (brecht) accepted this revision.Nov 10 2021, 12:20 PM
This revision is now accepted and ready to land.Nov 10 2021, 12:20 PM
Brecht Van Lommel (brecht) added a comment.Nov 10 2021, 12:21 PM

Indeed, not much that can be done for files already saved with a newer version, since it's unclear which socket it was then intended to animate.

Closed by commit rBaa2f6e597708: Fix T92979: Emission Strength Animation read wrong in 3.0 (authored by Philipp Oeser (lichtwerk)). · Explain WhyNov 10 2021, 12:46 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBaa2f6e597708: Fix T92979: Emission Strength Animation read wrong in 3.0.

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
5 lines

Diff 44573

View Options

source/blender/blenloader/intern/versioning_300.c

Loading...