Details

Reviewers

Philipp Oeser (lichtwerk)
Campbell Barton (campbellbarton)

Maniphest Tasks

T90866: Fix Python operator templates are not accessible from menus

Commits

rBda14a482f281: Fix T90866: Python operator templates are not accessible from menus

Summary

T90866: Python Operator templates made accessible from respective menus

Added Python Operators to respective Menus

Fixed Modal Draw Operator id_name

Diff Detail

Repository: rB Blender

Event Timeline

Diptangshu Dey (Tha_Hobbist) requested review of this revision.Nov 11 2021, 5:30 AM

Diptangshu Dey (Tha_Hobbist) created this revision.

Harbormaster completed remote builds in B18586: Diff 44608.Nov 11 2021, 5:30 AM

Philipp Oeser (lichtwerk) retitled this revision from Fixed: Python operator templates are not accessible from menus to Fix T90866: Python operator templates are not accessible from menus.Nov 11 2021, 2:56 PM

Philipp Oeser (lichtwerk) added a project: Python API.

Philipp Oeser (lichtwerk) added a task: T90866: Fix Python operator templates are not accessible from menus.

Thx for this!

Regarding the code comments (lloks like this was just copy-pasted from export example, so "file selector" is not appropriate for all examples.):

# Register and add to the file selector

It would also be good to mention that adding to a menu is needed to show up in F3 search, suggest something like the following (and make sure this is placed in all files -- right now some have this, some dont)

# Register and add to the "XYZ" menu (required to also use F3 search "ZXY" for quick access)

Philipp Oeser (lichtwerk) requested changes to this revision.Nov 11 2021, 3:20 PM

This revision now requires changes to proceed.Nov 11 2021, 3:20 PM

The patch looks fine, agree with @Philipp Oeser (lichtwerk) 's comment.

revised comments

Harbormaster completed remote builds in B18645: Diff 44720.Nov 13 2021, 5:51 PM

Philipp Oeser (lichtwerk) added inline comments.Nov 15 2021, 8:45 AM

doc/python_api/examples/bpy.types.Operator.1.py
49	please add the (required to use F3 search.... part here as well
doc/python_api/examples/bpy.types.Operator.3.py
35	please add the (required to use F3 search.... part here as well
doc/python_api/examples/bpy.types.Operator.4.py
48	please add the (required to use F3 search.... part here as well
doc/python_api/examples/bpy.types.Operator.5.py
62	please add the (required to use F3 search.... part here as well
doc/python_api/examples/bpy.types.Operator.6.py
38	please add the (required to use F3 search.... part here as well
doc/python_api/examples/bpy.types.Operator.py
29	please add the (required to use F3 search.... part here as well

added required comments

Harbormaster completed remote builds in B18658: Diff 44749.Nov 15 2021, 8:55 AM

Philipp Oeser (lichtwerk) requested changes to this revision.Nov 16 2021, 9:03 AM

Philipp Oeser (lichtwerk) added inline comments.

release/scripts/templates_py/operator_node.py
50	must be `self.layout` (instead of `self.layour`)

This revision now requires changes to proceed.Nov 16 2021, 9:03 AM

fixed typos

Harbormaster completed remote builds in B18680: Diff 44789.Nov 16 2021, 9:14 AM

Philipp Oeser (lichtwerk) accepted this revision.Nov 16 2021, 9:35 AM

This revision is now accepted and ready to land.Nov 16 2021, 9:35 AM

Closed by commit rBda14a482f281: Fix T90866: Python operator templates are not accessible from menus (authored by Diptangshu Dey (Tha_Hobbist), committed by Philipp Oeser (lichtwerk)). · Explain WhyNov 16 2021, 10:56 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBda14a482f281: Fix T90866: Python operator templates are not accessible from menus.

Fix T90866: Python operator templates are not accessible from menus
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 44793

doc/python_api/examples/bpy.types.Operator.1.py

doc/python_api/examples/bpy.types.Operator.2.py

doc/python_api/examples/bpy.types.Operator.3.py

doc/python_api/examples/bpy.types.Operator.4.py

doc/python_api/examples/bpy.types.Operator.5.py

doc/python_api/examples/bpy.types.Operator.6.py

doc/python_api/examples/bpy.types.Operator.py

release/scripts/templates_py/operator_file_export.py

release/scripts/templates_py/operator_file_import.py

release/scripts/templates_py/operator_mesh_add.py

release/scripts/templates_py/operator_mesh_uv.py

release/scripts/templates_py/operator_modal.py

release/scripts/templates_py/operator_modal_draw.py

release/scripts/templates_py/operator_modal_timer.py

release/scripts/templates_py/operator_modal_view3d.py

release/scripts/templates_py/operator_modal_view3d_raycast.py

release/scripts/templates_py/operator_node.py

release/scripts/templates_py/operator_simple.py

Fix T90866: Python operator templates are not accessible from menusClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44793

doc/python_api/examples/bpy.types.Operator.1.py

doc/python_api/examples/bpy.types.Operator.2.py

doc/python_api/examples/bpy.types.Operator.3.py

doc/python_api/examples/bpy.types.Operator.4.py

doc/python_api/examples/bpy.types.Operator.5.py

doc/python_api/examples/bpy.types.Operator.6.py

doc/python_api/examples/bpy.types.Operator.py

release/scripts/templates_py/operator_file_export.py

release/scripts/templates_py/operator_file_import.py

release/scripts/templates_py/operator_mesh_add.py

release/scripts/templates_py/operator_mesh_uv.py

release/scripts/templates_py/operator_modal.py

release/scripts/templates_py/operator_modal_draw.py

release/scripts/templates_py/operator_modal_timer.py

release/scripts/templates_py/operator_modal_view3d.py

release/scripts/templates_py/operator_modal_view3d_raycast.py

release/scripts/templates_py/operator_node.py

release/scripts/templates_py/operator_simple.py

Fix T90866: Python operator templates are not accessible from menus
ClosedPublic
Actions

Revision Contents
Changeset List