Page MenuHome
Differential D13189

Cleanup CUDA / HIP comments.
ClosedPublic
Actions

Authored by Thomas Dinges (dingto) on Nov 11 2021, 3:51 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rC35e6ef089af3: Cleanup CUDA / HIP comments
rB25e7365d0d69: Cleanup CUDA / HIP comments
Summary

Remove outdated CUDA comments for bindless textures and cleanup some HIP comments that still mentioned CUDA.

Diff Detail

Repository
rB Blender

Event Timeline

Thomas Dinges (dingto) requested review of this revision.Nov 11 2021, 3:51 PM
Thomas Dinges (dingto) created this revision.
Brecht Van Lommel (brecht) requested changes to this revision.Nov 11 2021, 4:15 PM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/device/hip/device_impl.cpp
379–383

This comment is still relevant, we don't officially support it but if you try to use adaptive compilation with HIP this will be an issue.

This revision now requires changes to proceed.Nov 11 2021, 4:15 PM
Thomas Dinges (dingto) updated this revision to Diff 44629.Nov 11 2021, 4:20 PM

Add back comment, but remove the cuCTX line, as that is CUDA specific.

Thomas Dinges (dingto) marked an inline comment as done.Nov 11 2021, 4:20 PM
Brecht Van Lommel (brecht) accepted this revision.Nov 11 2021, 4:23 PM
This revision is now accepted and ready to land.Nov 11 2021, 4:23 PM
Closed by commit rB25e7365d0d69: Cleanup CUDA / HIP comments (authored by Thomas Dinges (dingto)). · Explain WhyNov 11 2021, 4:38 PM
This revision was automatically updated to reflect the committed changes.
Thomas Dinges (dingto) added a commit: rB25e7365d0d69: Cleanup CUDA / HIP comments.
Brecht Van Lommel (brecht) added a commit: rC35e6ef089af3: Cleanup CUDA / HIP comments.Jan 27 2022, 11:36 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
device/
cuda/
2 lines
hip/
7 lines
2 lines

Diff 44633

View Options

intern/cycles/device/cuda/device_impl.cpp

Loading...
View Options

intern/cycles/device/hip/device_impl.cpp

Loading...
View Options

intern/cycles/device/hip/graphics_interop.h

Loading...