Fix T92601: Disable profiling when the profiler is deemed not active.
ClosedPublic
Actions

Authored by William Leeson (leesonw) on Nov 11 2021, 3:52 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T92601: Super LOW performance on CPU rendering in complex scene

Commits

rC64337d890b30: Fix T92601: Disable profiling when the profiler is deemed not active.
rB456876208b16: Fix T92601: Disable profiling when the profiler is deemed not active.
rB32c768785991: Fix T92601: Disable profiling when the profiler is deemed not active.

Summary

Adds a method to profiler that can be used to check if it is active.
This is used to determine if stop_profiling and start_profiling
should be called.

patch	Juans Scene UI 256 samples	Juans Scene bg 256 samples	junkshop UI	junkshop bg
No patch	6:16.59	4:05.37	2:08.48	1:59.7
D13187	4:12.15	3:57.36	2:07.25	1:58.16
D13185	4.11.18	3:54.74	2:07.44	1:58.03
D13190	4:12.39	3:55.42	2:07.62	1:58.68

UI - means rendered from within Blender
bg - means rendered from the command line using blender -b scene.blend -f 1

Diff Detail

Repository

rB Blender

Branch

deviceProfileCheck (branched from master)

Build Status

Buildable 18596
Build 18596: arc lint + arc unit

Event Timeline

William Leeson (leesonw) requested review of this revision.Nov 11 2021, 3:52 PM

William Leeson (leesonw) created this revision.

Harbormaster completed remote builds in B18596: Diff 44627.Nov 11 2021, 3:52 PM

William Leeson (leesonw) added a task: T92601: Super LOW performance on CPU rendering in complex scene.Nov 11 2021, 3:52 PM

William Leeson (leesonw) mentioned this in T92601: Super LOW performance on CPU rendering in complex scene.

Some performance data on the three patches

patch	Juans Scene UI 256 samples	Juans Scene bg 256 samples	junkshop UI	junkshop bg
No patch	6:16.59	4:05.37	2:08.48	1:59.7
D13187	4:12.15	3:57.36	2:07.25	1:58.16
D13185	4.11.18	3:54.74	2:07.44	1:58.03
D13190	4:12.39	3:55.42	2:07.62	1:58.68

UI - means rendered from within Blender
bg - means rendered from the command line using blender -b scene.blend -f 1

William Leeson (leesonw) edited the summary of this revision. (Show Details)Nov 11 2021, 3:56 PM

William Leeson (leesonw) added reviewers: Sergey Sharybin (sergey), Brecht Van Lommel (brecht).

William Leeson (leesonw) added a project: Render & Cycles.

Sergey Sharybin (sergey) accepted this revision.Nov 11 2021, 4:02 PM

Sergey Sharybin (sergey) added 1 blocking reviewer(s): Brecht Van Lommel (brecht).

Sergey Sharybin (sergey) added inline comments.

intern/cycles/util/profiling.h
99	Pedantic: `bool active() const;`

Brecht Van Lommel (brecht) accepted this revision.Nov 11 2021, 4:16 PM

This revision is now accepted and ready to land.Nov 11 2021, 4:16 PM

Let's go with this one and close the other patches.

Add const to active.

Harbormaster completed remote builds in B18599: Diff 44631.Nov 11 2021, 4:23 PM

William Leeson (leesonw) retitled this revision from Disable profiling when the profiler is deemed not active. to Fixes T92601:Disable profiling when the profiler is deemed not active..Nov 11 2021, 4:38 PM

William Leeson (leesonw) retitled this revision from Fixes T92601:Disable profiling when the profiler is deemed not active. to Fix T92601: Disable profiling when the profiler is deemed not active..

Brecht Van Lommel (brecht) accepted this revision.Nov 11 2021, 5:01 PM

Closed by commit rB32c768785991: Fix T92601: Disable profiling when the profiler is deemed not active. (authored by William Leeson (leesonw)). · Explain WhyNov 12 2021, 10:08 AM

This revision was automatically updated to reflect the committed changes.

William Leeson (leesonw) added a commit: rB32c768785991: Fix T92601: Disable profiling when the profiler is deemed not active..

William Leeson (leesonw) added a commit: rB456876208b16: Fix T92601: Disable profiling when the profiler is deemed not active..Nov 12 2021, 10:22 AM

Brecht Van Lommel (brecht) added a commit: rC64337d890b30: Fix T92601: Disable profiling when the profiler is deemed not active..Jan 27 2022, 11:31 PM