Page MenuHome
Differential D13191

PoseLib: use bpy.utils.flip_name()
ClosedPublic
Actions

Authored by Demeter Dzadik (Mets) on Nov 11 2021, 4:56 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Commits
rBAd4c8716c5b68: PoseLib: use bpy.utils.flip_name()
Summary

Instead of re-implementing BLI_string_flip_side_name, use the python function that was exposed in D12322.

Diff Detail

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.Nov 11 2021, 4:56 PM
Demeter Dzadik (Mets) created this revision.
Harbormaster completed remote builds in B18600: Diff 44634.Nov 11 2021, 4:56 PM
Sybren A. Stüvel (sybren) requested changes to this revision.Jan 28 2022, 3:13 PM

👍 on the patch, just one small nag.

pose_library/pose_usage.py
25

flip_name is not a very well-known name, so I'd prefer import bpy.utils and then calling bpy.utils.filp_name later in the code.

This revision now requires changes to proceed.Jan 28 2022, 3:13 PM
Demeter Dzadik (Mets) updated this revision to Diff 47690.Jan 28 2022, 3:53 PM

address feedback

Harbormaster completed remote builds in B20213: Diff 47690.Jan 28 2022, 3:53 PM
Demeter Dzadik (Mets) marked an inline comment as done.Jan 28 2022, 3:53 PM
Sybren A. Stüvel (sybren) accepted this revision.Jan 28 2022, 4:48 PM
This revision is now accepted and ready to land.Jan 28 2022, 4:48 PM
Closed by commit rBAd4c8716c5b68: PoseLib: use bpy.utils.flip_name() (authored by Demeter Dzadik (Mets)). · Explain WhyJan 31 2022, 11:31 AM
This revision was automatically updated to reflect the committed changes.
Demeter Dzadik (Mets) added a commit: rBAd4c8716c5b68: PoseLib: use bpy.utils.flip_name().

Revision Contents
Changeset List

PathSize
pose_library/
124 lines

Diff 47690

View Options

pose_library/pose_usage.py

Loading...