Page MenuHome
Differential D13194

Fix: Attribute Transfer node does not work with a single index.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 11 2021, 6:30 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rBbd734cc4419a: Fix: Attribute Transfer node does not work with a single index
Summary


index_transfer_bug.blend786 KBDownload

This changes the code so that instead of a FieldInput the index transfer also uses a MultiFunction.
As a side effect this change slightly modifies the behavior of the node when the target contains a mesh and a point cloud.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 11 2021, 6:30 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18603: Diff 44640.Nov 11 2021, 6:30 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 11 2021, 6:31 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 11 2021, 6:33 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) accepted this revision.Nov 11 2021, 6:58 PM

Looks good. I had it implemented this way at some point too, before I realized I "needed" to make it a field input to get the matching component behavior.

source/blender/nodes/geometry/nodes/node_geo_transfer_attribute.cc
589–590

I'd call this find_target_component, since there's no matching going on anymore.

This revision is now accepted and ready to land.Nov 11 2021, 6:58 PM
Closed by commit rBbd734cc4419a: Fix: Attribute Transfer node does not work with a single index (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 11 2021, 7:50 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBbd734cc4419a: Fix: Attribute Transfer node does not work with a single index.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
116 lines

Diff 44642

View Options

source/blender/nodes/geometry/nodes/node_geo_transfer_attribute.cc

Loading...