Cleanup: const, autoreleasepool, remove unneeded cast.
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Nov 13 2021, 12:48 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Group Reviewers

Platform: macOS

Commits

rB96387a2eff97: Cleanup: const, autoreleasepool, remove unneeded cast.

Summary

De-duplicate getSystemDir and getUserDir also.

Not sure why this file has NSASCIIStringEncoding all over. Change it to UTF8 ?

Diff Detail

Repository: rB Blender

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Nov 13 2021, 12:48 PM

Ankit Meel (ankitm) created this revision.

Harbormaster completed remote builds in B18639: Diff 44714.Nov 13 2021, 12:48 PM

Ankit Meel (ankitm) added a child revision: D13212: macOS: add tilde based path expander.Nov 13 2021, 1:00 PM

Ankit Meel (ankitm) added a reviewer: Platform: macOS.Nov 14 2021, 6:38 PM

need to check if static char tempPath[512] = ""; works the same or not since there's one function now
Maybe I'll allocate it in caller.

Brecht Van Lommel (brecht) requested changes to this revision.Nov 26 2021, 2:44 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) added inline comments.

intern/ghost/intern/GHOST_SystemPathsCocoa.mm
43–48	Don't share the same `static` variable for all paths, there should be one per path so they don't overwrite each other.

separate arrays

Harbormaster completed remote builds in B19162: Diff 45588.Dec 2 2021, 6:46 PM

Ankit Meel (ankitm) marked an inline comment as done.Dec 2 2021, 6:47 PM

Brecht Van Lommel (brecht) accepted this revision.Dec 9 2021, 9:03 PM

This revision is now accepted and ready to land.Dec 9 2021, 9:03 PM

Closed by commit rB96387a2eff97: Cleanup: const, autoreleasepool, remove unneeded cast. (authored by Ankit Meel (ankitm)). · Explain WhyDec 11 2021, 2:37 PM

This revision was automatically updated to reflect the committed changes.

Ankit Meel (ankitm) added a commit: rB96387a2eff97: Cleanup: const, autoreleasepool, remove unneeded cast..

Revision Contents
Changeset List

Path

Size

intern/

ghost/

intern/

GHOST_SystemPathsCocoa.mm

169 lines

Diff 45937

View Options

intern/ghost/intern/GHOST_SystemPathsCocoa.mm

Cleanup: const, autoreleasepool, remove unneeded cast.ClosedPublicActions