It's also not clear to me that GHOST_kUserSpecialDirLibrary is a good abstraction for GHOST, since that concept does not exist for other platforms. I would think more specific ones like GHOST_kUserSpecialDirFonts would be better.

This revision now requires changes to proceed.Nov 26 2021, 2:47 PM

Discard ghost: implementing GHOST_kUserSpecialDirHome or GHOST_kUserSpecialDirFonts for windows creates dependence on blenlib AFAIK. So used storage_apple.mm since expanding ~/ can count as a directory operation.

I thought about adding BLI_mac_user_home_dir to storage_apple.mm but then there'd be two functions (that and BKE_appdir_folder_home) doing the same thing.

Harbormaster completed remote builds in B19166: Diff 45593.Dec 2 2021, 8:44 PM

Ankit Meel (ankitm) removed a reviewer: Ray Molenkamp (LazyDodo).Dec 2 2021, 8:45 PM

Brecht Van Lommel (brecht) accepted this revision.Dec 9 2021, 9:02 PM

This revision is now accepted and ready to land.Dec 9 2021, 9:02 PM

Closed by commit rB9df13fba69c3: macOS: add tilde-based path expander (authored by Ankit Meel (ankitm)). · Explain WhyDec 11 2021, 6:00 PM

This revision was automatically updated to reflect the committed changes.

Ankit Meel (ankitm) added a commit: rB9df13fba69c3: macOS: add tilde-based path expander.