Page MenuHome
Differential D13213

Cleanup: reuse BKE function, fix comments
Needs ReviewPublic
Actions

Authored by Ankit Meel (ankitm) on Nov 13 2021, 12:57 PM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Sybren A. Stüvel (sybren)
Group Reviewers
Platform: macOS
Summary

Reuse BKE_appdir_folder_home.
Fix documentation comments.

Depends on D13212

Diff Detail

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Nov 13 2021, 12:57 PM
Ankit Meel (ankitm) created this revision.
Harbormaster completed remote builds in B18641: Diff 44716.Nov 13 2021, 12:57 PM
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Nov 13 2021, 1:00 PM
Ankit Meel (ankitm) added a parent revision: D13212: macOS: add tilde based path expander.
Ankit Meel (ankitm) added a child revision: D13214: File Browser: change location of thumbnail file cache.
Ankit Meel (ankitm) mentioned this in D12802: UI: Default Fonts Folder for Mac and Linux.Nov 13 2021, 1:07 PM
Ankit Meel (ankitm) added reviewers: Ray Molenkamp (LazyDodo), Campbell Barton (campbellbarton), Platform: macOS.Nov 14 2021, 6:44 PM
Ray Molenkamp (LazyDodo) requested changes to this revision.Nov 14 2021, 7:32 PM
Ray Molenkamp (LazyDodo) added inline comments.
source/blender/blenkernel/intern/appdir.c
159–160

Below you the flipped the order and changed #ifndef to an #ifdef greatly improving the readability, would be nice to do so here as well.

This revision now requires changes to proceed.Nov 14 2021, 7:32 PM
Ankit Meel (ankitm) updated this revision to Diff 44737.Nov 14 2021, 8:00 PM

Review: flip ifdef in BKE_appdir_folder_default also.

Add trailing slash in Unix in BKE_appdir_font_folder_default so that the following works well:

  • In VSE, add text to timeline.
  • In the N-panel, next to the Font ID data button (F), click open. Better user experience is the fonts folder opening, not its parent.
Harbormaster completed remote builds in B18652: Diff 44737.Nov 14 2021, 8:00 PM
Ankit Meel (ankitm) updated this revision to Diff 44738.Nov 14 2021, 8:02 PM
Ankit Meel (ankitm) marked an inline comment as done.

Fix comment
Mark comment done

Harbormaster completed remote builds in B18653: Diff 44738.Nov 14 2021, 8:02 PM
Ankit Meel (ankitm) updated this revision to Diff 44741.Nov 14 2021, 10:38 PM

Windows: Fix comment about cache folder path
Linux: reuse BKE_appdir_folder_home

Harbormaster completed remote builds in B18655: Diff 44741.Nov 14 2021, 10:38 PM
Brecht Van Lommel (brecht) accepted this revision.Nov 26 2021, 2:45 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenkernel/intern/appdir.c
301

This change should be committed separately.

Ankit Meel (ankitm) updated this revision to Diff 45594.Dec 2 2021, 8:58 PM
Ankit Meel (ankitm) retitled this revision from macOS: use GHOST instead of HOME environment var to Cleanup: reuse BKE function, fix comments.
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Since ghost was removed (pending approval), this is simpler now.

Harbormaster completed remote builds in B19167: Diff 45594.Dec 2 2021, 8:58 PM
Ray Molenkamp (LazyDodo) accepted this revision.Dec 12 2021, 2:52 AM

This is mostly shuffling the order around for things on windows, i see nothing concerning me.

Ankit Meel (ankitm) updated this revision to Diff 49540.Mar 22 2022, 3:17 PM
  • Add tests
Harbormaster completed remote builds in B21175: Diff 49540.Mar 22 2022, 3:17 PM
Ankit Meel (ankitm) added a reviewer: Sybren A. Stüvel (sybren). Ankit Meel (ankitm) removed 1 blocking reviewer(s): Campbell Barton (campbellbarton).Mar 22 2022, 3:20 PM
This revision is now accepted and ready to land.Mar 22 2022, 3:20 PM
Ankit Meel (ankitm) requested review of this revision.Mar 22 2022, 3:20 PM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
19 lines
editors/
space_file/
4 lines

Diff 45594

View Options

source/blender/blenkernel/intern/appdir.c

Loading...
View Options

source/blender/editors/space_file/fsmenu.c

Loading...