append code from WM to new `BKE_blendflie_link_append` module.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Nov 15 2021, 3:32 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Maniphest Tasks

T91414: Unify link/append between WM operators and BPY context manager API, and cleanup usages of `BKE_library_make_local`

Commits

rBfe274d91a129: Link/Append: Move most of core link/append code from WM to new…

Summary

This will allow to expose all those advanced features of the WM
operators to other parts of the code, like the python library context
manager, copy/paste code, etc.

This is expected to be a strictly no-behavioral-change commit.

Part of T91414: Unify link/append between WM operators and BPY context
manager API, and cleanup usages of BKE_library_make_local.

NOTE: This is strictly same code as what was before in WM area. Requesting review essentially to ensure that new names are OK for everyone.

Diff Detail

Repository: rB Blender

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Nov 15 2021, 3:32 PM

Bastien Montagne (mont29) created this revision.

Harbormaster completed remote builds in B18663: Diff 44758.Nov 15 2021, 3:32 PM

Bastien Montagne (mont29) edited the summary of this revision. (Show Details)Nov 15 2021, 3:34 PM

Bastien Montagne (mont29) added projects: Core, BF Blender.

Bastien Montagne (mont29) removed a subscriber: Core.

Bastien Montagne (mont29) mentioned this in T91414: Unify link/append between WM operators and BPY context manager API, and cleanup usages of `BKE_library_make_local`.Nov 16 2021, 9:34 AM

Brecht Van Lommel (brecht) accepted this revision.Nov 16 2021, 4:52 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/blenkernel/BKE_blendfile_link_append.h
64	Would calling this `userdata` follow the naming conventions more than `customdata`? I don't know what this will be used for though.

This revision is now accepted and ready to land.Nov 16 2021, 4:52 PM

Updated 'customdata' -> 'userdata'.

Harbormaster completed remote builds in B18869: Diff 45091.Nov 22 2021, 4:52 PM

Thanks for the review, renamed customdata to userdata as suggested. This will be used by other parts of code being ported to this system in future commits (relocating libraries/IDs code, and the python bpy.data.libraries.load code).

Closed by commit rBfe274d91a129: Link/Append: Move most of core link/append code from WM to new… (authored by Bastien Montagne (mont29)). · Explain WhyNov 22 2021, 4:55 PM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rBfe274d91a129: Link/Append: Move most of core link/append code from WM to new….