Paths

Table of Contentst

Differential D13243

Cycles: add packed_float3 type for storage
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Nov 16 2021, 3:50 PM.

Tags

None

Subscribers

None

Details

Reviewers

Michael Jones (michael_jones)

Maniphest Tasks

T92212: Cycles Metal device

Commits

rC3e5067769211: Add packed_float3 type for storage
rB9937d5379ca9: Cycles: add packed_float3 type for storage

Summary

Introduce a packed_float3 type for smaller storage that is exactly 3
floats, instead of 4. For computation float3 is still used since it can
use SIMD instructions.

Diff Detail

Repository

Build Status

Buildable 18707
Build 18707: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Nov 16 2021, 3:50 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B18699: Diff 44815.Nov 16 2021, 3:50 PM

Brecht Van Lommel (brecht) added a child revision: D13244: Cycles: reduce triangle memory usage with packed_float3.Nov 16 2021, 3:50 PM

Brecht Van Lommel (brecht) mentioned this in D13236: Cycles: Integrator array float3 packing considerations for MSL.Nov 16 2021, 3:51 PM

Michael Jones (michael_jones) added inline comments.Nov 16 2021, 4:54 PM

intern/cycles/util/types_float3.h
60	Is CUDA's `float3` 12 bytes in size / 4 byte aligned (e.g. https://github.com/ROCm-Developer-Tools/HIP/issues/706)? In which case could this be `#define packed_float3` float3 on CUDA?

Use float3 for CUDA, give error using float3 for device_memory.

Harbormaster completed remote builds in B18707: Diff 44825.Nov 16 2021, 5:20 PM

This looks good and I expect it will fit very cleanly with Metal.

This revision is now accepted and ready to land.Nov 16 2021, 9:45 PM

Brecht Van Lommel (brecht) added a task: T92212: Cycles Metal device.Nov 17 2021, 5:16 PM

Closed by commit rB9937d5379ca9: Cycles: add packed_float3 type for storage (authored by Brecht Van Lommel (brecht)). · Explain WhyNov 17 2021, 6:26 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB9937d5379ca9: Cycles: add packed_float3 type for storage.

Brecht Van Lommel (brecht) added a commit: rC3e5067769211: Add packed_float3 type for storage.Jan 27 2022, 11:37 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

device/

11 lines

kernel/

device/

cuda/

1 line

hip/

1 line

metal/

1 line

optix/

1 line

film/

2 lines

integrator/

shade_surface.h

13 lines

7 lines

shadow_state_template.h

12 lines

state_template.h

18 lines

util/

2 lines

26 lines

35 lines

Diff 44825

intern/cycles/device/memory.h

Loading...

intern/cycles/kernel/device/cuda/compat.h

Loading...

intern/cycles/kernel/device/hip/compat.h

Loading...

intern/cycles/kernel/device/metal/compat.h

Loading...

intern/cycles/kernel/device/optix/compat.h

Loading...

intern/cycles/kernel/film/accumulate.h

Loading...

intern/cycles/kernel/integrator/shade_surface.h

Loading...

intern/cycles/kernel/integrator/shade_volume.h

Loading...

intern/cycles/kernel/integrator/shadow_state_template.h

Loading...

intern/cycles/kernel/integrator/state_template.h

Loading...

intern/cycles/util/defines.h

Loading...

intern/cycles/util/math_float3.h

Loading...

intern/cycles/util/types_float3.h

Loading...