Fix T93130: Frame Selected with selected paint mask does not work
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 16 2021, 8:27 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Sergey Sharybin (sergey)

Maniphest Tasks

T93130: View/Frame Selected (Vertex Paint mode) not working

Commits

rB678610031345: Fix T93130: Frame Selected with selected paint mask does not work
rBb02bdd52a414: Fix T93130: Frame Selected with selected paint mask does not work
rBa773cd3850ee: Fix T93130: Frame Selected with selected paint mask does not work

Summary

This broke with rB20fac2eca723: The Death Of Editmesh - Part 1 (which landed in 2.63), so long
standing bug.

Convention for paint modes is:

when no paint mask is active, Frame Selected will focus the last stroke
when paint mask is active, Frame Selected will focus the selected mask faces

To check the right vert coords we have to offset with mp->loopstart.

Diff Detail

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 16 2021, 8:27 PM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)

Philipp Oeser (lichtwerk) added a task: T93130: View/Frame Selected (Vertex Paint mode) not working.

@Joseph Eagar (joeedh): since Campbell is on holiday, you could also give green light if you like?

Philipp Oeser (lichtwerk) added a reviewer: Sergey Sharybin (sergey).Nov 26 2021, 10:08 AM

Sergey Sharybin (sergey) accepted this revision.Nov 26 2021, 10:54 AM

This revision is now accepted and ready to land.Nov 26 2021, 10:54 AM

Closed by commit rBa773cd3850ee: Fix T93130: Frame Selected with selected paint mask does not work (authored by Philipp Oeser (lichtwerk)). · Explain WhyNov 26 2021, 2:37 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBa773cd3850ee: Fix T93130: Frame Selected with selected paint mask does not work.

Philipp Oeser (lichtwerk) added a commit: rBb02bdd52a414: Fix T93130: Frame Selected with selected paint mask does not work.Nov 28 2021, 5:24 PM

Philipp Oeser (lichtwerk) added a commit: rB678610031345: Fix T93130: Frame Selected with selected paint mask does not work.Jan 17 2022, 3:56 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

mesh/

editface.c

2 lines

Diff 44833

View Options

source/blender/editors/mesh/editface.c

Fix T93130: Frame Selected with selected paint mask does not workClosedPublicActions