Page MenuHome

Fix T92847: Meta-strip corrupt
ClosedPublic

Authored by Richard Antalik (ISS) on Nov 17 2021, 5:20 AM.

Details

Summary

Offsets for meta strip were invalid. No steps to reproduce the issue are
available, but it is quite possible that there are files with incorrect
state after issues with meta strips were fixed.

Ensure correct offsets for meta strips in versioning code.

Diff Detail

Repository
rB Blender
Branch
meta-fix (branched from master)
Build Status
Buildable 18727
Build 18727: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Nov 17 2021, 5:20 AM
Richard Antalik (ISS) created this revision.

Were there indeed fixes in the meta area which would have resolved the root cause?

source/blender/blenloader/intern/versioning_300.c
2207

Add a comment like:

/* Make sure range of meta strips is correct.
 * It was possible to save .blend file with incorrect state of meta strip
 * range. The root cause is expected to be fixed, but need to ensire those
 * files with invalid meta strips range are corrected. */
Richard Antalik (ISS) marked an inline comment as done.
  • Add comment

Were there indeed fixes in the meta area which would have resolved the root cause?

There have been fixes for issue that causes same behavior, so I think it's likely that main issue has been resolved.

This revision is now accepted and ready to land.Nov 18 2021, 9:21 AM
This revision was automatically updated to reflect the committed changes.