Page MenuHome

Nodes: Add bf_nodes_geometry library.
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Nov 17 2021, 12:19 PM.

Details

Summary

Separating geometry nodes into a separate library should allow us to use precompiled headers and unity builds to speedup build-times more easily. Especially unity builds benefit from this. Previously we had to make changes to all node systems to use unity builds. Now only geometry nodes has to be changed.

See P2578 for more details for how much unity builds can help us improve compile times.

Diff Detail

Repository
rB Blender
Branch
temp-geometry-nodes-lib (branched from master)
Build Status
Buildable 18735
Build 18735: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 17 2021, 12:19 PM
Jacques Lucke (JacquesLucke) created this revision.

Seems reasonable I suppose, and it works for me. Though it's too bad that we have to add things like WITH_GMP to geometry nodes and nodes.

There's no reason it needs to be like that, these defines could propagate on their own based on the targets requirements, but essentially we're using cmake wrong, D12122 is a step in the right direction, but it's a boring and tedious job, so i've been kinda been dragging my heels on it.

This revision is now accepted and ready to land.Nov 18 2021, 9:15 PM
This revision was automatically updated to reflect the committed changes.