Page MenuHome

Fix T93102: Principled hair shader stack was built incorrectly
ClosedPublic

Authored by William Leeson (leesonw) on Nov 17 2021, 2:37 PM.

Details

Summary

stack_assign_if was used in the middle of creating the shader value blocks.
Which caused stack variables to be inserted in the middle of the shader value data.
This resulted in the shader node data no being in sequential order. This was also
the case for the wave texture wave node.

Diff Detail

Repository
rB Blender
Branch
hairFix (branched from master)
Build Status
Buildable 18739
Build 18739: arc lint + arc unit

Event Timeline

William Leeson (leesonw) requested review of this revision.Nov 17 2021, 2:37 PM
William Leeson (leesonw) created this revision.

The images are now the same regardless of it the value is connect or set in the shader node. See images below

Value node connectedValue set in Shader

Good fine, just minor comments about code style that you can address in the comment.

intern/cycles/kernel/svm/closure.h
799

Leave out white space changes in this file.

intern/cycles/scene/shader_nodes.cpp
3603

Use /**/ for comments.

This revision is now accepted and ready to land.Nov 17 2021, 4:18 PM

Update formatting and comments.

William Leeson (leesonw) marked an inline comment as done.Nov 18 2021, 9:16 AM