build_files/build_environment/patches/config_gmpxx.h
529	This typo actually exists in upstream GMP, unsure if it's a typo or petty behavior on their end, but i'd rather not change things in automatically generated files and/or patches.

This revision now requires changes to proceed.Nov 17 2021, 4:00 PM

luzpaz (luzpaz) added inline comments.Nov 18 2021, 2:57 PM

build_files/build_environment/patches/config_gmpxx.h
529	Makes sense. What's the upstream repo URL?

reverted upstream patch + rebased

luzpaz (luzpaz) marked an inline comment as done.Nov 18 2021, 3:06 PM

Ray Molenkamp (LazyDodo) added inline comments.Nov 18 2021, 5:50 PM

build_files/build_environment/patches/config_gmpxx.h
529	I have to admit, unsure how they deal with patches, their main site is https://gmplib.org/

config_gmpxx.h is still in the patch but I'll exclude it in the commit.

Brecht Van Lommel (brecht) removed a reviewer: Ray Molenkamp (LazyDodo).Nov 19 2021, 1:16 PM

This revision is now accepted and ready to land.Nov 19 2021, 1:16 PM

Closed by commit rB7d5ef64bfb26: Cleanup: fix typos in comments and docs (authored by Brecht Van Lommel (brecht)). · Explain WhyNov 19 2021, 1:16 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB7d5ef64bfb26: Cleanup: fix typos in comments and docs.

Revision Contents
Changeset List

Path

Size

CMakeLists.txt

4 lines

GNUmakefile

2 lines

build_files/

build_environment/

cmake/

2 lines

2 lines

4 lines

2 lines

patches/

config_gmpxx.h

2 lines

cmake/

cmake_netbeans_project.py

2 lines

source/

blender/

blenfont/

intern/

blf_font.c

2 lines

blenkernel/

BKE_global.h

2 lines

intern/

2 lines

4 lines

2 lines

2 lines

2 lines

2 lines

2 lines

blenlib/

intern/

BLI_mempool.c

2 lines

draw/

engines/

eevee/

shaders/

ambient_occlusion_lib.glsl

4 lines

closure_eval_lib.glsl

4 lines

common_utiltex_lib.glsl

2 lines

effect_dof_gather_frag.glsl

2 lines

effect_dof_reduce_frag.glsl

2 lines

effect_reflection_resolve_frag.glsl

2 lines

random_lib.glsl

2 lines

surface_lib.glsl

2 lines

volumetric_lib.glsl

2 lines

gpencil/

gpencil_engine.h

2 lines

workbench/

shaders/

workbench_effect_dof_frag.glsl

2 lines

editors/

animation/

anim_channels_defines.c

2 lines

freestyle/

intern/

view_map/

FEdgeXDetector.cpp

2 lines

imbuf/

intern/

indexer.c

6 lines

io/

avi/

intern/

avi.c

2 lines

collada/

AnimationExporter.cpp

2 lines

makesdna/

DNA_fluid_types.h

4 lines

DNA_lightprobe_types.h

2 lines

makesrna/

intern/

rna_object_api.c

2 lines

nodes/

geometry/

nodes/

node_geo_image_texture.cc

2 lines

tests/

performance/

api/

graph.py

2 lines

python/

bl_blendfile_liblink.py

8 lines

bl_blendfile_library_overrides.py

6 lines

bl_keymap_validate.py

2 lines

Diff 44914

View Options

CMakeLists.txt

View Options

GNUmakefile

View Options

build_files/build_environment/cmake/harvest.cmake

View Options

build_files/build_environment/cmake/options.cmake

View Options

build_files/build_environment/cmake/package_python.cmake

View Options

build_files/build_environment/install_deps.sh

View Options

build_files/build_environment/patches/config_gmpxx.h

View Options

build_files/cmake/cmake_netbeans_project.py

View Options

source/blender/blenfont/intern/blf_font.c

View Options

source/blender/blenkernel/BKE_global.h

View Options

source/blender/blenkernel/intern/constraint.c

View Options

source/blender/blenkernel/intern/dynamicpaint.c

View Options

source/blender/blenkernel/intern/fluid.c

View Options

source/blender/blenkernel/intern/lib_override.c

View Options

source/blender/blenkernel/intern/material.c

View Options

source/blender/blenkernel/intern/softbody.c

View Options

source/blender/blenkernel/intern/text.c

View Options

source/blender/blenlib/intern/BLI_mempool.c

View Options

source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/closure_eval_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/common_utiltex_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/effect_dof_gather_frag.glsl

View Options

source/blender/draw/engines/eevee/shaders/effect_dof_reduce_frag.glsl

View Options

source/blender/draw/engines/eevee/shaders/effect_reflection_resolve_frag.glsl

View Options

source/blender/draw/engines/eevee/shaders/random_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/surface_lib.glsl

View Options

source/blender/draw/engines/eevee/shaders/volumetric_lib.glsl

View Options

source/blender/draw/engines/gpencil/gpencil_engine.h

View Options

source/blender/draw/engines/workbench/shaders/workbench_effect_dof_frag.glsl

View Options

source/blender/editors/animation/anim_channels_defines.c

View Options

source/blender/freestyle/intern/view_map/FEdgeXDetector.cpp

View Options

source/blender/imbuf/intern/indexer.c

View Options

source/blender/io/avi/intern/avi.c

View Options

source/blender/io/collada/AnimationExporter.cpp

View Options

source/blender/makesdna/DNA_fluid_types.h

View Options

source/blender/makesdna/DNA_lightprobe_types.h

View Options

source/blender/makesrna/intern/rna_object_api.c

View Options

source/blender/nodes/geometry/nodes/node_geo_image_texture.cc

View Options

tests/performance/api/graph.py

View Options

tests/python/bl_blendfile_liblink.py

View Options

tests/python/bl_blendfile_library_overrides.py

View Options

tests/python/bl_keymap_validate.py

Cleanup: fix typos in comments and docsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44914

CMakeLists.txt

GNUmakefile

build_files/build_environment/cmake/harvest.cmake

build_files/build_environment/cmake/options.cmake

build_files/build_environment/cmake/package_python.cmake

build_files/build_environment/install_deps.sh

build_files/build_environment/patches/config_gmpxx.h

build_files/cmake/cmake_netbeans_project.py

source/blender/blenfont/intern/blf_font.c

source/blender/blenkernel/BKE_global.h

source/blender/blenkernel/intern/constraint.c

source/blender/blenkernel/intern/dynamicpaint.c

source/blender/blenkernel/intern/fluid.c

source/blender/blenkernel/intern/lib_override.c

source/blender/blenkernel/intern/material.c

source/blender/blenkernel/intern/softbody.c

source/blender/blenkernel/intern/text.c

source/blender/blenlib/intern/BLI_mempool.c

source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl

source/blender/draw/engines/eevee/shaders/closure_eval_lib.glsl

source/blender/draw/engines/eevee/shaders/common_utiltex_lib.glsl

source/blender/draw/engines/eevee/shaders/effect_dof_gather_frag.glsl

source/blender/draw/engines/eevee/shaders/effect_dof_reduce_frag.glsl

source/blender/draw/engines/eevee/shaders/effect_reflection_resolve_frag.glsl

source/blender/draw/engines/eevee/shaders/random_lib.glsl

source/blender/draw/engines/eevee/shaders/surface_lib.glsl

source/blender/draw/engines/eevee/shaders/volumetric_lib.glsl

source/blender/draw/engines/gpencil/gpencil_engine.h

source/blender/draw/engines/workbench/shaders/workbench_effect_dof_frag.glsl

source/blender/editors/animation/anim_channels_defines.c

source/blender/freestyle/intern/view_map/FEdgeXDetector.cpp

source/blender/imbuf/intern/indexer.c

source/blender/io/avi/intern/avi.c

source/blender/io/collada/AnimationExporter.cpp

source/blender/makesdna/DNA_fluid_types.h

source/blender/makesdna/DNA_lightprobe_types.h

source/blender/makesrna/intern/rna_object_api.c

source/blender/nodes/geometry/nodes/node_geo_image_texture.cc

tests/performance/api/graph.py

tests/python/bl_blendfile_liblink.py

tests/python/bl_blendfile_library_overrides.py

tests/python/bl_keymap_validate.py

Cleanup: fix typos in comments and docs
ClosedPublic
Actions

Revision Contents
Changeset List