Spline Length Node
- Add Spline Point Count Output
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Curve Length Node
- add Curve Total Points
- add Spline Count
Spline Length
- add Spline Point Count
- add Segment Length
| source/blender/nodes/geometry/nodes/node_geo_curve_length.cc | ||
|---|---|---|
| 40–41 ↗ | (On Diff #45009) | These functions allocate arrays, and shouldn't be called when only the last value is needed. Since this keeps coming up, maybe this patch could add total_length() and point_size() functions to CurveEval |
Comment Actions
- Merge branch 'master' into curvelengthnode
- Remove declarations of new CurveEval functions
Comment Actions
- Merge branch 'master' into curvelengthnode
- Split segment length out into it's own node
Comment Actions
- Merge branch 'master' into curvelengthnode
- Split Spline point count out to its own patch
Comment Actions
Looking good. It would be nice to have a screenshot of the node in the patch.
Just a few smaller code style comments.
| source/blender/nodes/geometry/nodes/node_geo_input_spline_length.cc | ||
|---|---|---|
| 29 | There's a section about sections in the style guide: https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments I think for this case I like the style after the following non-doxy sections are also acceptable: | |
| 104 | This should use spline.size() directly, rather than the size of only the positions. Functionally it's the same, but it's just a little clearer. | |
| 115 | Return {} instead. | |
Comment Actions
Looks good! Please wait for committing until we decide about node socket versioning tomorrow though.
Also, the patch description could use a few more words describing what this does to someone with less context than us.
| source/blender/nodes/geometry/nodes/node_geo_input_spline_length.cc | ||
|---|---|---|
| 33 | Could you add a newline after these comment sections? | |