Fix T93189: Missing UNDO operator options for Curve Tools addon
ClosedPublic
Actions

Authored by Jesse Yurkovich (deadpin) on Nov 19 2021, 10:03 AM.

Details

Reviewers

Vladimir Spivak (cwolf3d)
Campbell Barton (campbellbarton)

Maniphest Tasks

T93189: Curve tools: Crash on undo operation

Commits

rBA7685aa17ce3d: Fix T93189: Missing UNDO operator options for Curve Tools addon
rBA94ebaf049229: Fix T93189: Missing UNDO operator options for Curve Tools addon

Summary

A variety of operators were missing appropriate bl_options for correct
undo support.

This results in either crashes (auto loft, bi-rail) or other odd
behaviors around returning the scene to the correct previous state
(sometimes having to hit ctrl-z twice to undo once, sometimes undo skips
steps, etc.)

This needs to go to the 3.0 branch.

Diff Detail

Repository

rBA Blender Add-ons

Branch

fixcurve (branched from blender-v3.0-release)

Build Status

Buildable 18784
Build 18784: arc lint + arc unit

Event Timeline

Jesse Yurkovich (deadpin) requested review of this revision.Nov 19 2021, 10:03 AM

Jesse Yurkovich (deadpin) created this revision.

Harbormaster completed remote builds in B18784: Diff 44963.Nov 19 2021, 10:03 AM

Jesse Yurkovich (deadpin) added a task: T93189: Curve tools: Crash on undo operation.Nov 19 2021, 10:04 AM

Jesse Yurkovich (deadpin) retitled this revision from Fix T93189: Missing UNDO operator options to Fix T93189: Missing UNDO operator options for Curve Tools addon.

Pratik Borhade (PratikPB2123) awarded a token.Nov 19 2021, 10:12 AM

@Vladimir Spivak (cwolf3d) Hi, hope it's ok if I added you as a reviewer here. You were the most recent, real, contributor to this particular addon.

Royster (Royston) awarded a token.Dec 9 2021, 9:01 PM

Missed a few other operators

Harbormaster completed remote builds in B19740: Diff 46571.Jan 4 2022, 5:45 AM

Jesse Yurkovich (deadpin) added a reviewer: Campbell Barton (campbellbarton).Jan 4 2022, 5:45 AM

Looks like this fix is not in:

Blender 3.0.1 - Release Candidate
January 18, 02:21:06 - 9600f36cfcba - zip - 234.17MB
x64

@Royster (Royston) Yes, because the fix is still waiting to be reviewed here.

@Vladimir Spivak (cwolf3d) I noticed you were active recently for this addon. Do you have time to review this change?

@Campbell Barton (campbellbarton) Might you have time to take a look at this one?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2022, 2:41 AM

Closed by commit rBA94ebaf049229: Fix T93189: Missing UNDO operator options for Curve Tools addon (authored by Jesse Yurkovich (deadpin)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Jesse Yurkovich (deadpin) added a commit: rBA94ebaf049229: Fix T93189: Missing UNDO operator options for Curve Tools addon.

Philipp Oeser (lichtwerk) added a commit: rBA7685aa17ce3d: Fix T93189: Missing UNDO operator options for Curve Tools addon.Sep 19 2022, 2:59 PM

Revision Contents
Changeset List

Path

Size

curve_tools/

auto_loft.py

1 line

operators.py

6 lines

Diff 44963

View Options

curve_tools/auto_loft.py