Fix (unreported) broken handling of constraints reordering with liboverride.
AbandonedPublic
Actions

Authored by Bastien Montagne (mont29) on Nov 19 2021, 6:01 PM.

Details

Reviewers

Julian Eisel (Severin)
Campbell Barton (campbellbarton)

Commits

rB6eaa69c66c98: Fix (unreported) broken handling of constraints reordering with liboverride.

Summary

New drag&drop reordering code would call constraints reordering operator
with the generic context, and not the one from the panel's layout.
missing the "constraint" member which is mandatory for poll function to
properly deal with override vs. local constraints.

This commit fixes it by generating a temp bContextStore in the panel
re-ordering callback.

NOTE: this fix will have to be extended to modifiers (which happen to work currently because they have an 'active' status), and gpencil modifiers (which are also broken currently).

Diff Detail

Repository: rB Blender

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Nov 19 2021, 6:01 PM

Bastien Montagne (mont29) created this revision.

Harbormaster completed remote builds in B18813: Diff 45002.Nov 19 2021, 6:01 PM

Just to leave a note here: I would prefer to solve this for all of these panel data stacks by letting the panel copy the context-store of the layout and setting that for calling the reorder callback. When executing the callback the layout is already destructed, so we'd have to copy the context earlier.
I think it's easy to do this, but I need to check.

In D13291#350857, @Julian Eisel (Severin) wrote:

Just to leave a note here: I would prefer to solve this for all of these panel data stacks by letting the panel copy the context-store of the layout and setting that for calling the reorder callback. When executing the callback the layout is already destructed, so we'd have to copy the context earlier.
I think it's easy to do this, but I need to check.

@Julian Eisel (Severin) Please keep in mind that we need to fix that for 3.0 (and backport the fix to 2.93)... So think we could live with a simple and safe solution for those releases, and try better generic fix for 3.1?

This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2021, 9:34 AM

Closed by commit rB6eaa69c66c98: Fix (unreported) broken handling of constraints reordering with liboverride. (authored by Bastien Montagne (mont29)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rB6eaa69c66c98: Fix (unreported) broken handling of constraints reordering with liboverride..

Bastien Montagne (mont29) added a reverting change: rB0b246ed8131f: Revert "Fix (unreported) broken handling of constraints reordering with….Nov 22 2021, 10:40 AM

Fix committed by mistake, reverted now.

Julian Eisel (Severin) mentioned this in D13308: Fix (unreported) broken handling of constraints reordering with liboverride..Nov 22 2021, 3:24 PM

Julian Eisel (Severin) mentioned this in rB792badcfefcb: Fix broken handling of constraints reordering with library overrides.Nov 23 2021, 6:35 PM

I think this can be closed?

yes indeed