Page MenuHome

Geometry Nodes: Support instances in Transfer/Capture Attribute nodes
ClosedPublic

Authored by Erik Abrahamsson (erik85) on Nov 19 2021, 6:27 PM.

Details

Summary

Updates the Transfer Attributes and Capture Attributes nodes
to support instance attributes.

This file can be used to demo the Transfer Attributes node:

Diff Detail

Repository
rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Nov 19 2021, 6:27 PM
Erik Abrahamsson (erik85) created this revision.
Hans Goudey (HooglyBoogly) requested changes to this revision.Nov 19 2021, 6:32 PM

Just a small change inline.

source/blender/nodes/geometry/nodes/node_geo_attribute_capture.cc
149–172

These two cases should go in a if (domain == ATTR_DOMAIN_INSTANCE) { ... } else { ... } block.
Otherwise, it's less clear that nested instances should be affected by the node with the instance domain selected.
The node would also waste time going through other components and nested instance geometry trying to capture on the instance domain.

171

Add a comment, something like /* Run on the instances component separately to only affect the top level of instances. */

This revision now requires changes to proceed.Nov 19 2021, 6:32 PM
  • Add if-statement to decide if nested geometry sets or only top level should be captured.
Erik Abrahamsson (erik85) marked 2 inline comments as done.Nov 19 2021, 7:03 PM
This revision is now accepted and ready to land.Nov 19 2021, 7:09 PM