VSE: Add support for dropped Image, Movie Clip and Sound data-blocks
ClosedPublic
Actions

Authored by Peter Fog (tintwotin) on Nov 22 2021, 7:29 AM.

Details

Reviewers

Richard Antalik (ISS)

Commits

rBb42494cf6b00: VSE: Support drag and drop for datablocks

Summary

For using the Outliner and/or the Asset Browser as scene independent tools to organize a/v source material is necessary for the users to be able to drag and drop data blocks into the VSE. This was also an unfulfilled design target for the Outliner Gsoc project.

For testing, this scrip can be used to convert selected strips to assets, if the experimental asset browser elements are enabled under Preferences: https://gist.github.com/tin2tin/0da859896432245fd15cfe960fdd9ee9

Additional findings:

Dragged and dropped folders and for the vse unknown file types like text, html, diff etc. imports adds an image strip with an invalid path.
I have a vague recollection of folders that could be dragged and dropped into the vse, but if it was working at some point it has been broken for several versions back.
Drag and drop of ID's of cameras and texts, could also be supported.
Drag and drop of paths of movie, sound, text and image from the outliner, could also be supported, but it seems like it's the drag part is missing.

Diff Detail

Repository: rB Blender

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Nov 22 2021, 7:29 AM

Peter Fog (tintwotin) created this revision.

The way you modified original code is incorrect, now you can't drop movies. This worked with original patch you shared in chat. I am not quite sure why this change was done.

This revision now requires changes to proceed.Nov 22 2021, 7:47 AM

Revert path(not ID) code.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Nov 22 2021, 8:22 AM

Richard Antalik (ISS) accepted this revision.Nov 22 2021, 8:31 AM

This revision is now accepted and ready to land.Nov 22 2021, 8:31 AM

Philipp Oeser (lichtwerk) awarded a token.Nov 22 2021, 9:00 AM

Peter Fog (tintwotin) mentioned this in D13305: Asset Browser: Draw Movie Clip previews.Nov 22 2021, 10:03 AM

Peter Fog (tintwotin) added a project: VFX & Video.Nov 22 2021, 3:03 PM

@Sergey Sharybin (sergey) Can this ^be committed? And this one: D13305

With some minor tweak to name it can indeed be committed.

source/blender/editors/space_sequencer/space_sequencer.c
454	`sequencer_id_path_drop_copy` -> `sequencer_id_or_path_drop_copy` ID path is something else.

Peter Fog (tintwotin) mentioned this in D13311: VSE: Add drop into Preview.Nov 22 2021, 4:04 PM

Updated to solve the @Sergey Sharybin (sergey) comment. NB. I do not have commit rights.

Peter Fog (tintwotin) marked an inline comment as done.Nov 22 2021, 4:23 PM

HEYPictures (HEYPictures) awarded a token.Nov 22 2021, 5:30 PM

Looks like you have included bit more changes.

I will do some changes here anyway, because I noticed, this code isn't formatted with clang-format, and so each WM_dropbox_add call will take 4 lines. So I will revert name back to sequencer_drop_copy and merge poll functions so there is only 1 for each strip type. Other editors do it this way too.

Closed by commit rBb42494cf6b00: VSE: Support drag and drop for datablocks (authored by Peter Fog (tintwotin), committed by Richard Antalik (ISS)). · Explain WhyNov 23 2021, 5:41 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rBb42494cf6b00: VSE: Support drag and drop for datablocks.

Andres Stephens (Draise) awarded a token.Nov 25 2021, 4:33 PM

Andrea Monzini (Andrea_Monzini) awarded a token.Dec 4 2021, 1:52 PM

Peter Fog (tintwotin) mentioned this in D15333: Fix T99255: Strips inserting incorrectly.Jul 12 2022, 4:37 PM