Page MenuHome
Differential D13313

Fix T93092: Incomplete animation rendering of multi-layer exr composition.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 22 2021, 4:38 PM.

Details

Reviewers
Philipp Oeser (lichtwerk)
Brecht Van Lommel (brecht)
Maniphest Tasks
T93092: Incomplete Animation Rendering of MultiLayer EXR composition
Commits
rBb02ac2d8be38: Fix T93092: incomplete animation rendering of multi-layer exr composition
Summary

Loading multi-layer exr files has some special handling at least since rB253432bfc7c2: The Big Image refactor!. I don't fully understand how the multi-layer exr files are handled exactly, but this fix seems reasonable and solves the issue in the original file.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 22 2021, 4:38 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18864: Diff 45084.Nov 22 2021, 4:38 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 22 2021, 4:41 PM
Jacques Lucke (JacquesLucke) added reviewers: Philipp Oeser (lichtwerk), Brecht Van Lommel (brecht).Nov 22 2021, 4:43 PM

Tests are running here: https://builder.blender.org/admin/#/builders/18/builds/170.

Jacques Lucke (JacquesLucke) added a task: T93092: Incomplete Animation Rendering of MultiLayer EXR composition.Nov 22 2021, 4:44 PM
Brecht Van Lommel (brecht) accepted this revision.Nov 22 2021, 5:59 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenkernel/intern/image.c
4266

Can you add a comment explaining this? Like:

/* NULL ibuf in the cache means the image failed to load. However for multilayer we load pixels into RenderResult instead and intentionally leave ibuf NULL. */
This revision is now accepted and ready to land.Nov 22 2021, 5:59 PM
Closed by commit rBb02ac2d8be38: Fix T93092: incomplete animation rendering of multi-layer exr composition (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 23 2021, 9:43 AM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBb02ac2d8be38: Fix T93092: incomplete animation rendering of multi-layer exr composition.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
51 lines

Diff 45127

View Options

source/blender/blenkernel/intern/image.c

Loading...