Page MenuHome
Differential D13315

Fix T92654: Missing padding in spreadsheet cells.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 22 2021, 5:17 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T92654: Fix padding issue in spreadsheet
Commits
rB84be741329bc: Fix T92654: missing padding in spreadsheet cells
Summary

Old


New

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 22 2021, 5:17 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18870: Diff 45094.Nov 22 2021, 5:17 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 22 2021, 5:18 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

Do you have a reference to the commit that broke the padding?

Jacques Lucke (JacquesLucke) added a task: T92654: Fix padding issue in spreadsheet.Nov 22 2021, 5:19 PM
Hans Goudey (HooglyBoogly) accepted this revision.Nov 22 2021, 6:39 PM

I just finished bisecting this issue. Apparently it's caused by 5c2330203e11e0d916960218b07d88d2193bf526. I don't understand why that commit is correct, it seems pretty arbitrary. Oh well... if that ever changes we can remove this padding too.

This revision is now accepted and ready to land.Nov 22 2021, 6:39 PM
Closed by commit rB84be741329bc: Fix T92654: missing padding in spreadsheet cells (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 23 2021, 9:38 AM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB84be741329bc: Fix T92654: missing padding in spreadsheet cells.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_spreadsheet/
8 lines

Diff 45126

View Options

source/blender/editors/space_spreadsheet/spreadsheet_draw.cc

Loading...