Page MenuHome
Differential D13326

Fix T93231: Crash when overwriting vertex group with other domain.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 23 2021, 10:18 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T93231: geometry nodes, crash when attribute domain set to 'edge' when outputting to vertex weights
Commits
rBdab04bc0536f: Fix T93231: crash when overwriting vertex group with other domain
Summary

The problem was that we forgot to actually remove the vertex group when it should be deleted. We only removed all the data that was attached to it.

Diff Detail

Repository
rB Blender
Branch
missing-vertex-group-removal (branched from master)
Build Status
Buildable 18891
Build 18891: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 23 2021, 10:18 AM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18891: Diff 45133.Nov 23 2021, 10:18 AM
Jacques Lucke (JacquesLucke) added a task: T93231: geometry nodes, crash when attribute domain set to 'edge' when outputting to vertex weights.Nov 23 2021, 10:18 AM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Jacques Lucke (JacquesLucke) added a comment.Nov 23 2021, 10:21 AM

Tests are running here: https://builder.blender.org/admin/#/builders/18/builds/177.

Hans Goudey (HooglyBoogly) accepted this revision.EditedNov 23 2021, 1:46 PM

The change makes perfect sense, nice find.

EDIT: Maybe we could add that file as a regression test? It's pretty easy and there's no real downside.

This revision is now accepted and ready to land.Nov 23 2021, 1:46 PM
Jacques Lucke (JacquesLucke) added a comment.Nov 23 2021, 2:34 PM

EDIT: Maybe we could add that file as a regression test? It's pretty easy and there's no real downside.

Sounds like a good idea. Feel free to add it.

Closed by commit rBdab04bc0536f: Fix T93231: crash when overwriting vertex group with other domain (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 23 2021, 2:38 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBdab04bc0536f: Fix T93231: crash when overwriting vertex group with other domain.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
4 lines
intern/
28 lines
11 lines

Diff 45133

View Options

source/blender/blenkernel/BKE_deform.h

Loading...
View Options

source/blender/blenkernel/intern/deform.c

Loading...
View Options

source/blender/blenkernel/intern/geometry_component_mesh.cc

Loading...