Page MenuHome
Differential D13333

Fix T93296: Raycast node uses wrong domain for face corner attributes.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 23 2021, 12:40 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T93296: Raycast Node uses wrong domain for Face Corner attributes
Commits
rB436ce2219414: Fix T93296: raycast node uses wrong domain for face corner attributes
Summary

This changes what domain is used by the raycast mode. This should fix the behavior for face corner attributes (but may make it a bit slower for other attributes). I think for 3.0 this is an acceptable trade off. For 3.1 we can do what the comment suggests already.

Diff Detail

Repository
rB Blender
Branch
raycast-domain-fix (branched from master)
Build Status
Buildable 18898
Build 18898: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 23 2021, 12:40 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18898: Diff 45144.Nov 23 2021, 12:40 PM
Jacques Lucke (JacquesLucke) added a task: T93296: Raycast Node uses wrong domain for Face Corner attributes.Nov 23 2021, 12:40 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) accepted this revision.Nov 23 2021, 1:42 PM

Oof, I was hoping that wouldn't be necessary yet-- the old version of the node worked that way too. Thanks!

This revision is now accepted and ready to land.Nov 23 2021, 1:42 PM
Closed by commit rB436ce2219414: Fix T93296: raycast node uses wrong domain for face corner attributes (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 23 2021, 2:38 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB436ce2219414: Fix T93296: raycast node uses wrong domain for face corner attributes.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
8 lines

Diff 45144

View Options

source/blender/nodes/geometry/nodes/node_geo_raycast.cc

Loading...