Differential D13334

Fix T93297: Incorrect eevee motion blur with geometry instances.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 23 2021, 2:21 PM.

Tags

None

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T93297: Eevee motion blur or Geometry node is bugging material

Commits

rBa6b7f3211205: Fix T93297: incorrect eevee motion blur with geometry instances

Summary

From code comment:

/* Geometry instances do not support motion blur correctly yet. The #key used in
 * #motion_blur_deform_data_get has to take ids of instances (#DupliObject.persistent_id) into
 * account. Otherwise it can't find matching geometry instances at different points in time. */

For 3.1 we should find a better way to support motion blur for geometry instances (which can currently only be created with geometry nodes). Fundamentally changing how the mapping of objects at different times works for 3.0 seems a bit risky now.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 23 2021, 2:21 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B18901: Diff 45149.Nov 23 2021, 2:21 PM

typo

Harbormaster completed remote builds in B18902: Diff 45150.Nov 23 2021, 2:28 PM

cleanup

Harbormaster completed remote builds in B18903: Diff 45151.Nov 23 2021, 2:30 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 23 2021, 2:32 PM

Jacques Lucke (JacquesLucke) added a reviewer: Clément Foucault (fclem).

Jacques Lucke (JacquesLucke) added a task: T93297: Eevee motion blur or Geometry node is bugging material.

Jacques Lucke (JacquesLucke) mentioned this in T93297: Eevee motion blur or Geometry node is bugging material.Nov 23 2021, 2:52 PM

Clément Foucault (fclem) accepted this revision.Nov 23 2021, 3:11 PM

This revision is now accepted and ready to land.Nov 23 2021, 3:11 PM

Closed by commit rBa6b7f3211205: Fix T93297: incorrect eevee motion blur with geometry instances (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 23 2021, 4:41 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBa6b7f3211205: Fix T93297: incorrect eevee motion blur with geometry instances.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

eevee/

eevee_motion_blur.c

9 lines

Diff 45168

source/blender/draw/engines/eevee/eevee_motion_blur.c

Loading...