Page MenuHome
Differential D13337

Cleanup: Simplify geometry node function names
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Nov 23 2021, 4:10 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBfab39440e94d: Cleanup: Simplify geometry node function names
Summary

With this commit, we no longer use the prefixes for every node type
function like geo_node_translate_instances_. They just added more
places to change when adding a new node, for no real benefit.

Diff Detail

Repository
rB Blender
Branch
cleanup-simplify-node-function-names (branched from master)
Build Status
Buildable 18910
Build 18910: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 23 2021, 4:10 PM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B18910: Diff 45164.Nov 23 2021, 4:10 PM
Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).Nov 23 2021, 4:11 PM
Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.
Jacques Lucke (JacquesLucke) accepted this revision.Nov 23 2021, 4:46 PM

node_exec should be renamed to node_geo_exec, but we might have multiple exec functions. Besides that, LGTM.

This revision is now accepted and ready to land.Nov 23 2021, 4:46 PM
Hans Goudey (HooglyBoogly) updated this revision to Diff 45169.Nov 23 2021, 4:50 PM
  • Change node_exec to node_geo_exec
Harbormaster completed remote builds in B18912: Diff 45169.Nov 23 2021, 4:50 PM
Closed by commit rBfab39440e94d: Cleanup: Simplify geometry node function names (authored by Hans Goudey (HooglyBoogly)). · Explain WhyNov 23 2021, 4:57 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBfab39440e94d: Cleanup: Simplify geometry node function names.

Large Diff

This large diff affects 135 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
legacy/
22 lines
20 lines
18 lines
22 lines
22 lines
18 lines
36 lines
20 lines
16 lines
20 lines
20 lines
18 lines
18 lines
8 lines
22 lines
18 lines
22 lines
22 lines
8 lines
8 lines
18 lines
18 lines
18 lines
16 lines
20 lines
8 lines
8 lines
8 lines
8 lines
14 lines
20 lines
20 lines
20 lines
8 lines
20 lines
22 lines
20 lines
8 lines
18 lines
20 lines
22 lines
8 lines
22 lines
20 lines
8 lines
16 lines
8 lines
8 lines
16 lines
16 lines
18 lines
8 lines
8 lines
18 lines
22 lines
22 lines
8 lines
22 lines
8 lines
8 lines
16 lines
8 lines
20 lines
18 lines
18 lines
8 lines
8 lines
20 lines
20 lines
16 lines
14 lines
8 lines
16 lines
8 lines
8 lines
8 lines
8 lines
12 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
18 lines
22 lines
8 lines
20 lines
8 lines
8 lines
22 lines
8 lines
8 lines
8 lines
16 lines
16 lines
8 lines
22 lines
12 lines
20 lines
8 lines
8 lines
8 lines
8 lines
18 lines
18 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
8 lines
20 lines
18 lines
20 lines
22 lines
8 lines
8 lines
12 lines
16 lines
20 lines

Diff 45164

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_align_rotation_to_vector.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_clamp.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_color_ramp.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_combine_xyz.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_compare.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_convert.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_curve_map.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_fill.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_map_range.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_math.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_mix.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_proximity.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_randomize.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_sample_texture.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_separate_xyz.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_transfer.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_vector_math.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_attribute_vector_rotate.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_curve_endpoints.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_curve_reverse.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_curve_select_by_handle_type.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_curve_set_handles.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_curve_spline_type.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_curve_subdivide.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_curve_to_points.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_delete_geometry.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_edge_split.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_material_assign.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_mesh_to_curve.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_point_distribute.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_point_instance.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_point_rotate.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_point_scale.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_point_separate.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_point_translate.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_points_to_volume.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_raycast.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_select_by_material.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_subdivision_surface.cc

View Options

source/blender/nodes/geometry/nodes/legacy/node_geo_legacy_volume_to_mesh.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_capture.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_remove.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_boolean.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_bounding_box.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_collection_info.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_endpoint_selection.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_fill.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_handle_type_selection.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_length.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_parameter.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_bezier_segment.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_line.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_quadratic_bezier.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_quadrilateral.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_spiral.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_star.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_resample.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_reverse.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_sample.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_set_handles.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_to_mesh.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_to_points.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_delete_geometry.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_distribute_points_on_faces.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_edge_split.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_image_texture.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_curve_handles.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_curve_tilt.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_id.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_index.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_material.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_material_index.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_normal.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_position.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_radius.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_shade_smooth.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_spline_cyclic.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_spline_length.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_spline_resolution.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_tangent.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_is_viewport.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_material_replace.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_material_selection.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cube.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cylinder.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_grid.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_ico_sphere.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_line.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_subdivide.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_to_points.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_object_info.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_points_to_vertices.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_points_to_volume.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_proximity.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_raycast.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_realize_instances.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_scale_instances.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_separate_components.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_separate_geometry.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_curve_handles.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_curve_tilt.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_id.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_material.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_material_index.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_point_radius.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_position.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_shade_smooth.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_spline_cyclic.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_set_spline_resolution.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_string_join.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_string_to_curves.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_switch.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_transfer_attribute.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_transform.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_triangulate.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_viewer.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_volume_to_mesh.cc