Page MenuHome
Differential D13340

Geometry Nodes: Fix logging socket value to group input socket.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 23 2021, 5:39 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rB3844e9dbe771: Fix (unreported): unlinked group input is not logged in geometry nodes
Summary

Previously, this would show the info that the value has not been computed. Now it shows the socket value (only if it was actually used of course).

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 23 2021, 5:39 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18914: Diff 45172.Nov 23 2021, 5:39 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 23 2021, 5:40 PM
Jacques Lucke (JacquesLucke) updated this revision to Diff 45174.Nov 23 2021, 5:43 PM
  • comments
Harbormaster completed remote builds in B18915: Diff 45174.Nov 23 2021, 5:43 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).Nov 23 2021, 5:44 PM
Hans Goudey (HooglyBoogly) accepted this revision.EditedNov 23 2021, 6:10 PM

The change makes sense.

It might be helpful to describe what origin_socket means for this function in a comment. It took me a couple moments to remember that it's the socket from outside of a group, or (I think), the socket connected by reroutes?

This revision is now accepted and ready to land.Nov 23 2021, 6:10 PM
Closed by commit rB3844e9dbe771: Fix (unreported): unlinked group input is not logged in geometry nodes (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 23 2021, 7:05 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB3844e9dbe771: Fix (unreported): unlinked group input is not logged in geometry nodes.

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
18 lines

Diff 45187

View Options

source/blender/modifiers/intern/MOD_nodes_evaluator.cc

Loading...