Page MenuHome
Differential D13344

Remove developers' local pathnames from SVG files and remove deprecated gradients
ClosedPublic
Actions

Authored by Nikhil Shringarpurey (Nikhil.Net) on Nov 23 2021, 7:04 PM.

Details

Reviewers
Julian Eisel (Severin)
Yevgeny Makarov (jenkm)
Commits
rBe5858a3ad054: Icons: Remove absolute pathnames and deprecated gradients from SVG files
Summary

SVG files contained specific detailed pathnames on developers' computers. These included full local user profile and path and should not be in the release.

This patches corrects those lines. It also removes unused gradients from the private icons SVG.

Diff Detail

Repository
rB Blender

Event Timeline

Nikhil Shringarpurey (Nikhil.Net) requested review of this revision.Nov 23 2021, 7:04 PM
Nikhil Shringarpurey (Nikhil.Net) created this revision.
Nikhil Shringarpurey (Nikhil.Net) updated this revision to Diff 45192.Nov 23 2021, 8:37 PM
Nikhil Shringarpurey (Nikhil.Net) retitled this revision from Remove developers' local pathnames from SVG files to Remove developers' local pathnames from SVG files and remove deprecated gradients.
Nikhil Shringarpurey (Nikhil.Net) edited the summary of this revision. (Show Details)
Nikhil Shringarpurey (Nikhil.Net) added a reviewer: Yevgeny Makarov (jenkm).
Nikhil Shringarpurey (Nikhil.Net) added a subscriber: Yevgeny Makarov (jenkm).

All gradients (15,000+ lines worth) that were not used were removed from the SVG, as per @Yevgeny Makarov (jenkm).

Nikhil Shringarpurey (Nikhil.Net) updated this revision to Diff 45194.Nov 23 2021, 8:52 PM

Corrected file paths from *.svg to *.png.

Yevgeny Makarov (jenkm) accepted this revision.Nov 23 2021, 9:05 PM

Looks good to me, no changes in .dat files after make icons.

This revision is now accepted and ready to land.Nov 23 2021, 9:05 PM
Nikhil Shringarpurey (Nikhil.Net) updated this revision to Diff 45227.Nov 24 2021, 5:36 PM

Had to redo patch after 2cc56495f3ce9fb8d959c78f761602da019c958a was committed.

Julian Eisel (Severin) accepted this revision.Jan 12 2022, 2:55 PM
Closed by commit rBe5858a3ad054: Icons: Remove absolute pathnames and deprecated gradients from SVG files (authored by Nikhil Shringarpurey (Nikhil.Net), committed by Julian Eisel (Severin)). · Explain WhyJan 12 2022, 3:03 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) added a commit: rBe5858a3ad054: Icons: Remove absolute pathnames and deprecated gradients from SVG files.
Pablo Vazquez (pablovazquez) awarded a token.Jan 24 2022, 3:43 PM

Revision Contents
Changeset List

PathSize
release/
datafiles/
390 lines
16530 lines

Diff 45192

View Options

release/datafiles/blender_icons.svg

Loading...
View Options

release/datafiles/prvicons.svg

Loading...