Page MenuHome
Differential D13352

Fix black Cycles result when cancelling tiled rendering with shadow catcher
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Nov 24 2021, 3:55 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rC0afe78f3838d: Fix black Cycles result when cancelling tiled rendering with shadow catcher
rB40d28b40dfd0: Fix black Cycles result when cancelling tiled rendering with shadow catcher
Summary

Noticed when was looking into T93155. Steps to reproduce:

  • Open the .blend file from the report
  • Hit F12 to start rendering
  • After some tiles were rendered hit Esc

The issue is caused by "sticky" cancel reported via Progress. This means
that once user hit Esc all further requests for cancel state will return
truth, which was preventing OIDN denoiser from completing the denoising
task.

Now only allow stopping the denoiser when interactive rendering requests
a very fast stopping.

Aiming the fix for 3.0 branch.

Diff Detail

Repository
rB Blender
Branch
cycles_denoise_tile_cancel (branched from master)
Build Status
Buildable 18938
Build 18938: arc lint + arc unit

Revision Contents
Changeset List

PathSize
intern/
cycles/
integrator/
6 lines

Diff 45219

View Options

intern/cycles/integrator/path_trace.cpp

Loading...