Page MenuHome
Differential D13361

Clarify a confusing comment.
ClosedPublic
Actions

Authored by Martijn Versteegh (Baardaap) on Nov 24 2021, 11:02 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB004172de38d5: Clarify a confusing comment.
Summary

Affect and effect are too confusing for non-native english speakers
(like me). Also BAKING_MASK_MARGIN doesn't exist anymore in the code.

Diff Detail

Repository
rB Blender

Event Timeline

Martijn Versteegh (Baardaap) requested review of this revision.Nov 24 2021, 11:02 PM
Martijn Versteegh (Baardaap) created this revision.
Harbormaster completed remote builds in B18957: Diff 45256.Nov 24 2021, 11:02 PM
Sergey Sharybin (sergey) added a comment.Nov 25 2021, 9:45 AM

Suggested edit. Referring to "new pixels" is not that clear as there are no new pixels added to the image.

source/blender/imbuf/intern/filter.c
427
Martijn Versteegh (Baardaap) added a comment.Nov 25 2021, 5:46 PM

That's better indeed.

Could you commit it? I don't have commit access.

Martijn Versteegh (Baardaap) removed a reviewer: Campbell Barton (campbellbarton).Nov 25 2021, 5:46 PM
Martijn Versteegh (Baardaap) updated this revision to Diff 45286.Nov 25 2021, 5:53 PM
Martijn Versteegh (Baardaap) marked an inline comment as done.

Clarify a confising comment.

Affect and effect are too confusing for non-native english speakers
(like me). Also BAKING_MASK_MARGIN doesn't exist anymore in the code.

Harbormaster completed remote builds in B18975: Diff 45286.Nov 25 2021, 5:53 PM
Martijn Versteegh (Baardaap) updated this revision to Diff 45287.Nov 25 2021, 5:59 PM

Clarify a confusing comment.

Affect and effect are too confusing for non-native english speakers
(like me). Also BAKING_MASK_MARGIN doesn't exist anymore in the code.

Harbormaster completed remote builds in B18976: Diff 45287.Nov 25 2021, 5:59 PM
Martijn Versteegh (Baardaap) added a comment.Nov 25 2021, 6:00 PM

Ok, after some struggle with arc it seems to have uploaded ok now.

Could you commit it? I don't have commit access.

Sergey Sharybin (sergey) accepted this revision.Nov 26 2021, 10:56 AM

Thanks for the update. And yes, I will commit this.

This revision is now accepted and ready to land.Nov 26 2021, 10:56 AM
Closed by commit rB004172de38d5: Clarify a confusing comment. (authored by Martijn Versteegh (Baardaap), committed by Sergey Sharybin (sergey)). · Explain WhyNov 26 2021, 10:59 AM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rB004172de38d5: Clarify a confusing comment..

Revision Contents
Changeset List

PathSize
source/
blender/
imbuf/
intern/
6 lines

Diff 45298

View Options

source/blender/imbuf/intern/filter.c

Loading...