Differential D13362

Fix T93362: Crash when capturing attribute after fillet curve node.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 24 2021, 11:52 PM.

Tags

None

Subscribers

None

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T93362: Crash When Capturing Attribute after Fillet Curve Node

Commits

rB82808e18e656: Fix T93362: crash when capturing attribute after fillet curve node

Summary

The issue was that the attribute propagation in the Fillet Curve node seems pretty broken.. I can't really make sense of the old code.
It also changed the size of the point attribute on splines to 1 for some reason which led to a crash in the next node.

The following file works fine with this patch and shows the attribute propagation working.

fillet_attribute_propagation.blend804 KBDownload

Diff Detail

Repository

Branch

fillet-attribute-propagation (branched from master)

Build Status

Buildable 18959
Build 18959: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 24 2021, 11:52 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B18959: Diff 45258.Nov 24 2021, 11:52 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 24 2021, 11:56 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

Jacques Lucke (JacquesLucke) added a task: T93362: Crash When Capturing Attribute after Fillet Curve Node.

Yeah.. I can't quite tell what the code was meaning to do, it looks quite odd. Thanks for the fix.

This revision is now accepted and ready to land.Nov 25 2021, 5:48 AM

Closed by commit rB82808e18e656: Fix T93362: crash when capturing attribute after fillet curve node (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 25 2021, 10:36 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB82808e18e656: Fix T93362: crash when capturing attribute after fillet curve node.

Zhen Dai (zhendai) mentioned this in T99287: Regression: Resample Curve after Fillet Curve node cause crash randomly.Jun 30 2022, 6:36 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_curve_fillet.cc

7 lines

Diff 45258

source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc

Loading...