Differential D13365
Geometry Nodes: Add Domain Size Node Authored by Johnny Matthews (guitargeek) on Nov 25 2021, 7:12 AM. Tags Subscribers None Tokens
Details The Domain Size node has a single geometry input and a selection for the component type. Based on the component chosen, outputs containing single values for the related domains are shown. Mesh:
Curve:
Point Cloud:
Instances:
Diff Detail
Event TimelineComment Actions I guess I had assumed that we would have an output for every domain that exists on a geometry type. Since the most domains we have in a single type is four, I don't think that would make the node too big. How does that sound to you? Also, I think I'd make this an "Attribute" class node and put it in the attribute category, since it's dealing with attribute domain sizes.
Comment Actions Looking good!
Comment Actions Also, the patch description should be updated with a new screenshot, and it could contain a bit more information about what the node does for someone unfamiliar with the context. Comment Actions So should the name be "Attribute Domain Size" or just "Domain Size"? I'm fine with "Domain Size", but right now the title and the node name are inconsistent. I get a compiler warning. [1106/2286] Building CXX object source/blender/nodes/geometry/CMakeFiles/bf_nodes_geometry.dir/Unity/unity_4_cxx.cxx.o
In file included from /home/jacques/blender-git/build_linux/source/blender/nodes/geometry/CMakeFiles/bf_nodes_geometry.dir/Unity/unity_4_cxx.cxx:5:
/home/jacques/blender-git/blender/source/blender/nodes/geometry/nodes/node_geo_attribute_domain_size.cc: In function ‘void blender::nodes::node_geo_attribute_domain_size_cc::node_geo_exec(blender::nodes::GeoNodeExecParams)’:
/home/jacques/blender-git/blender/source/blender/nodes/geometry/nodes/node_geo_attribute_domain_size.cc:120:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
120 | }
| ^
/home/jacques/blender-git/blender/source/blender/nodes/geometry/nodes/node_geo_attribute_domain_size.cc:121:5: note: here
121 | default:
| ^~~~~~~Without fixing this, this crashes in a debug build and shows a warning in release builds. | ||||||||||||||||||||||||||||