Page MenuHome
Differential D13368

Fix T90082: Autoscrolling after renaming in the File Browser broken
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Nov 25 2021, 12:03 PM.

Details

Reviewers
Julian Eisel (Severin)
Bastien Montagne (mont29)
Maniphest Tasks
T90082: New autoscrolling after renaming in the File Browser works weird
Commits
rBb2bb3e4b722b: Fix T90082: Autoscrolling after renaming in the File Browser broken
Summary

Caused by rB6b0869039a40: File Browser: Select files and directories after renaming

Above commit introduced selection after renaming. This includes calling
file_select_deselect_all [which resorts and refilters].

So now, to have the correct file for scrolling, get it again after
sorting by calling file_params_find_renamed again.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Nov 25 2021, 12:03 PM
Philipp Oeser (lichtwerk) created this revision.
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)

@Bastien Montagne (mont29): added you as reviewer here since you worked on this as well in rB4326f8af08c845eeb4eb45800ca047f690044007

Philipp Oeser (lichtwerk) added a task: T90082: New autoscrolling after renaming in the File Browser works weird.Nov 25 2021, 12:04 PM
Julian Eisel (Severin) accepted this revision.Nov 25 2021, 5:29 PM

Didn't test this yet, but seems like a good catch. So if this at least mitigates the issue well, it's a fine fix.
Best to keep eyes open for further glitches with the smooth scrolling.

This revision is now accepted and ready to land.Nov 25 2021, 5:29 PM
Closed by commit rBb2bb3e4b722b: Fix T90082: Autoscrolling after renaming in the File Browser broken (authored by Philipp Oeser (lichtwerk), committed by Julian Eisel (Severin)). · Explain WhyNov 25 2021, 5:33 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) added a commit: rBb2bb3e4b722b: Fix T90082: Autoscrolling after renaming in the File Browser broken.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_file/
6 lines

Diff 45285

View Options

source/blender/editors/space_file/filesel.c

Loading...