Page MenuHome
Differential D13370

Fix T93274: Assigning asset catalog doesn't mark file as modified
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Nov 25 2021, 1:45 PM.

Details

Reviewers
Julian Eisel (Severin)
Maniphest Tasks
T93274: Assigning asset catalog doesn't mark file as modified
Commits
rBc91d1961596e: Fix T93274: Assigning asset catalog doesn't mark file as modified
Summary

Assigning a catalog to an asset via drag-and-drop in the asset browser
didn't tag the blend file as modified, even though this is information
that's stored in the blend file.

This patch adds a call to ED_undo_push() so that not only the blend file is marked as modified, but also the catalog assignment can be undone.

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Nov 25 2021, 1:45 PM
Sybren A. Stüvel (sybren) created this revision.
Harbormaster completed remote builds in B18968: Diff 45274.Nov 25 2021, 1:45 PM
Sybren A. Stüvel (sybren) added a task: T93274: Assigning asset catalog doesn't mark file as modified.Nov 25 2021, 1:45 PM
Sybren A. Stüvel (sybren) updated this revision to Diff 45279.Nov 25 2021, 2:36 PM
  • Push an undo step when dragging asset to catalog. This requires passing the context to on-drop functions.
Harbormaster completed remote builds in B18971: Diff 45279.Nov 25 2021, 2:36 PM
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)Nov 25 2021, 2:37 PM
Sybren A. Stüvel (sybren) added projects: Asset Browser, BF Blender (3.0).
Sybren A. Stüvel (sybren) updated this revision to Diff 45281.Nov 25 2021, 2:52 PM
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)
  • Do ED_undo_push after the data modification, not before. Also this ensures a single undo push is done (instead of one per modified asset).
Harbormaster completed remote builds in B18973: Diff 45281.Nov 25 2021, 2:52 PM
Julian Eisel (Severin) accepted this revision.Nov 25 2021, 2:54 PM
This revision is now accepted and ready to land.Nov 25 2021, 2:54 PM
Closed by commit rBc91d1961596e: Fix T93274: Assigning asset catalog doesn't mark file as modified (authored by Sybren A. Stüvel (sybren)). · Explain WhyNov 25 2021, 3:22 PM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rBc91d1961596e: Fix T93274: Assigning asset catalog doesn't mark file as modified.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
4 lines
2 lines
interface/
2 lines
6 lines
space_file/
31 lines

Diff 45283

View Options

source/blender/editors/include/UI_interface.h

Loading...
View Options

source/blender/editors/include/UI_tree_view.hh

Loading...
View Options

source/blender/editors/interface/interface_ops.c

Loading...
View Options

source/blender/editors/interface/tree_view.cc

Loading...
View Options

source/blender/editors/space_file/asset_catalog_tree_view.cc

Loading...