Page MenuHome

Fix T93380: Texture paint clone tool crash without clone image
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Nov 26 2021, 8:39 AM.

Details

Summary

This was crashing using the clone tool without a clone image assigned.

Caused by rB9111ea78acf4: Localize image mutex lock into runtime field of Image datablock.
Since above commit, BKE_image_acquire_ibuf was using ima->runtime
without checking for NULL first.
Since callers are not required to check for this, just return early
here.

note: there is still a memory leak using the clone tool without a clone
image assigned (but this was also the case before said commit and needs
to be investigated separately).

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) retitled this revision from Fix T93380: Texture paint clone tool crash to Fix T93380: Texture paint clone tool crash without clone image.Nov 26 2021, 9:48 AM
This revision is now accepted and ready to land.Nov 26 2021, 10:53 AM