Page MenuHome
Differential D13386

Nodes: Support internal links for custom sockets
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Nov 26 2021, 9:33 PM.
Tags
None
Subscribers
None
Tokens
"Love" token, awarded by hitrpr."Like" token, awarded by AlexeyAdamitsky."Love" token, awarded by iyadahmed2001.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Hans Goudey (HooglyBoogly)
Commits
rBf1118ee51ea0: Nodes: Support internal links for custom sockets
Summary

Currently, nodes with custom sockets do not get their internal links
populated. So operators like Delete And Reconnect don't work with such
nodes. This patch put custom sockets into consideration when computing
priorities for internal links such that sockets of the same idname get
connected. Additionally, the patch cleanup the function in the process
to avoid redundant code repetition.

Diff Detail

Repository
rB Blender
Branch
nodes-custom-sockets-internal-links (branched from master)
Build Status
Buildable 18997
Build 18997: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) requested review of this revision.Nov 26 2021, 9:33 PM
Omar Emara (OmarSquircleArt) created this revision.
Harbormaster completed remote builds in B18997: Diff 45326.Nov 26 2021, 9:33 PM
Jacques Lucke (JacquesLucke) requested changes to this revision.Nov 29 2021, 10:10 AM

Looks mostly good.

source/blender/nodes/intern/node_util.c
367

This is probably missing a break or return, otherwise it falls through into the SOCK_VECTOR case.

This revision now requires changes to proceed.Nov 29 2021, 10:10 AM
Omar Emara (OmarSquircleArt) updated this revision to Diff 45386.Nov 29 2021, 11:43 AM
  • Avoid potential fall through
Harbormaster completed remote builds in B19026: Diff 45386.Nov 29 2021, 11:43 AM
Jacques Lucke (JacquesLucke) accepted this revision.Nov 29 2021, 11:53 AM
This revision is now accepted and ready to land.Nov 29 2021, 11:53 AM
Closed by commit rBf1118ee51ea0: Nodes: Support internal links for custom sockets (authored by Omar Emara (OmarSquircleArt)). · Explain WhyNov 29 2021, 12:03 PM
This revision was automatically updated to reflect the committed changes.
Omar Emara (OmarSquircleArt) added a commit: rBf1118ee51ea0: Nodes: Support internal links for custom sockets.
Iyad Ahmed (iyadahmed2001) awarded a token.Dec 4 2021, 4:06 PM
Alexey Adamitsky (AlexeyAdamitsky) awarded a token.Dec 7 2021, 4:00 PM
Vyacheslav (hitrpr) awarded a token.Jan 26 2022, 1:05 PM

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
intern/
98 lines

Diff 45326

View Options

source/blender/nodes/intern/node_util.c

Loading...