Fix T93431.
Crash was introduced in 481f032f5cbe2cd3c36c9ef516670fd9e06db25f
make ED_preview_id_is_supported function NULL-safe
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| source/blender/editors/interface/interface_icons.c | ||
|---|---|---|
| 2048 | It would be better to have ED_preview_id_is_supported NULL-safe. You can just add if (id == NULL) { return false; } to the function. Semantically it makes sense as well, as NULL cannot have a preview. | |
Comment Actions
Adding @Jeroen Bakker (jbakker) as blocking reviewer as he's available to do the review (@Julian Eisel (Severin) is not, today).
Comment Actions
Would add the check to UI_icon_render_id as it is the only user and seems like there it also reads from uninitialized memory.
Add an pre-check assert in ED_preview_id_is_supported.