Page MenuHome
Differential D13400

Fix T93456: Properly translate operator on splash screen
ClosedPublic
Actions

Authored by Jesse Yurkovich (deadpin) on Nov 29 2021, 4:03 AM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rBb31250feba4c: Fix T93456: Properly translate operator on splash screen
Summary

Use the translation API to lookup the pre-formatted string.

Diff Detail

Repository
rB Blender

Event Timeline

Jesse Yurkovich (deadpin) requested review of this revision.Nov 29 2021, 4:03 AM
Jesse Yurkovich (deadpin) created this revision.
Harbormaster completed remote builds in B19019: Diff 45375.Nov 29 2021, 4:03 AM
Jesse Yurkovich (deadpin) edited the summary of this revision. (Show Details)Nov 29 2021, 4:04 AM
Jesse Yurkovich (deadpin) added a reviewer: Bastien Montagne (mont29).
Bastien Montagne (mont29) requested changes to this revision.Nov 29 2021, 9:03 AM

I do not understand that patch... First of all, explicit call to iface_ should not be needed here, those overriding text parameters of UI layout functions are automatically extracted. And you do can find this string in all the POs (and the blender.pot) files in i18n repo already...

So if it is not currently translated in the UI, the issue lies somewhere else.

This revision now requires changes to proceed.Nov 29 2021, 9:03 AM
Jesse Yurkovich (deadpin) added a comment.Nov 29 2021, 9:11 AM

The issue is that it's a formatted string, so "Load 2.93 Settings" is the value that is passed in and attempted to be translated.

Bastien Montagne (mont29) accepted this revision.Nov 29 2021, 10:53 AM

Oooooh right, good call.

Thanks, then LGTM.

This revision is now accepted and ready to land.Nov 29 2021, 10:53 AM
Bastien Montagne (mont29) added a comment.Nov 29 2021, 10:56 AM

And think this is OK for 3.0 too.

Closed by commit rBb31250feba4c: Fix T93456: Properly translate operator on splash screen (authored by Jesse Yurkovich (deadpin)). · Explain WhyNov 29 2021, 11:06 AM
This revision was automatically updated to reflect the committed changes.
Jesse Yurkovich (deadpin) added a commit: rBb31250feba4c: Fix T93456: Properly translate operator on splash screen.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_operators/
2 lines

Diff 45384

View Options

release/scripts/startup/bl_operators/wm.py

Loading...