Page MenuHome
Differential D13418

Fix T92988: keymap item expanding incorrectly
ClosedPublic
Actions

Authored by Jake (Welp) on Nov 29 2021, 10:50 PM.
Tags
Subscribers
None
Tokens
"Like" token, awarded by PratikPB2123."Love" token, awarded by jenkm."Like" token, awarded by mano-wii.

Details

Reviewers
Brecht Van Lommel (brecht)
Group Reviewers
User Interface
Maniphest Tasks
T92988: Weird collapsing behaviour in Keymap window
Commits
rB1c7c1480d1ac: Fix T92988: keymap item expanding incorrectly
Summary

"show_expansion" updates did not dirty the keymap diff cache, leading to old flags being written to the item when another item was edited

Diff Detail

Repository
rB Blender

Event Timeline

Jake (Welp) requested review of this revision.Nov 29 2021, 10:50 PM
Jake (Welp) created this revision.
Harbormaster completed remote builds in B19074: Diff 45452.Nov 29 2021, 10:50 PM
Jake (Welp) added a reviewer: User Interface.Nov 29 2021, 10:51 PM
Germano Cavalcante (mano-wii) awarded a token.Nov 30 2021, 1:30 PM
Yevgeny Makarov (jenkm) awarded a token.Nov 30 2021, 1:42 PM
Pratik Borhade (PratikPB2123) retitled this revision from Fix keymap item expanding incorrectly to Fix T92988: keymap item expanding incorrectly.Jan 4 2023, 7:22 AM
Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)
Pratik Borhade (PratikPB2123) added a project: User Interface.
Pratik Borhade (PratikPB2123) awarded a token.
Brecht Van Lommel (brecht) accepted this revision.Jan 4 2023, 2:01 PM
This revision is now accepted and ready to land.Jan 4 2023, 2:01 PM
Closed by commit rB1c7c1480d1ac: Fix T92988: keymap item expanding incorrectly (authored by • HaydenBerkson (Jake), committed by Brecht Van Lommel (brecht)). · Explain WhyJan 4 2023, 2:48 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB1c7c1480d1ac: Fix T92988: keymap item expanding incorrectly.

Revision Contents
Changeset List

PathSize
source/
blender/
makesrna/
intern/
1 line

Diff 59073

View Options

source/blender/makesrna/intern/rna_wm.c

Loading...