Combined view of timeline and preview causes seemingly unpredictable
behavior after some operators have been allowed to run in preview
region.
Disable new features in this combined view, so behavior should be
consistent with previous versions.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- no-interactivity (branched from master)
- Build Status
Buildable 19082 Build 19082: arc lint + arc unit
Event Timeline
Comment Actions
To avoid duplicate checks suggest sequencer_view_preview_only_poll(...).
Other changes:
- "Image" menu shouldn't be displayed.
- Strip "Delete" doesn't work (it should delete selected strips - ignoring preview).
- Eyedropper tool should be removed (tools should match sequencer only view).
- Pivot shouldn't be visible in the header (match sequence layout), except for color/alpha display options.
| source/blender/editors/transform/transform.c | ||
|---|---|---|
| 1756–1760 | Exiting from transform at this point is leaking memory: t->data_container. I think it would be most straight forward not to allocate any transform data and let the transform system exit early in the t->data_len_all == 0 block below. | |
| release/scripts/startup/bl_ui/space_sequencer.py | ||
|---|---|---|
| 247–248 | This is displayed in both views. These operators work on all strips so technically this shouldn't be included in preview strictly speaking. I think this could be included in all 3 editors | |
| source/blender/editors/transform/transform.c | ||
| 1756–1760 | Makes sense, I just checked that createTransSeqImageData doesn't return allocated data and looked for different place not realizing data is validated elsewhere. | |
Comment Actions
@Francesco Siddi (fsiddi) Why isn't this a valid solution, instead of crippling the Sequencer/Preview mode?
Sequencer/Preview:
Preview:
Proposed in this patch: https://developer.blender.org/D12513#352702
There is a build of D12513 here: https://builder.blender.org/download/patch/
| release/scripts/startup/bl_ui/space_sequencer.py | ||
|---|---|---|
| 247–248 | In this case I think it doesn't make sense to show them in the PREVIEW at all, although it may be best to modify them to support only visible strips (when preview is enabled), to avoid accidents. Whatever the case, it can be handled separately from this patch. | |