Cleanup: Store instances id attribute with other attributes
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Nov 30 2021, 6:11 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rBf8dd03d3dd1b: Cleanup: Store instances id attribute with other attributes

Summary

Now that we can store any dynamic attribute on the instances component,
we don't need the special case for id, it can just be handled by the generic
attribute storage. Mostly this just allows removing a bunch of redundant code.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 30 2021, 6:11 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B19109: Diff 45502.Nov 30 2021, 6:11 PM

Merge branch 'master' into cleanup-instances-id-dynamic
Cleanup

Harbormaster completed remote builds in B19119: Diff 45517.Dec 1 2021, 5:35 AM

Hans Goudey (HooglyBoogly) retitled this revision from Cleanup: Store instances id attribute with other attributes (WIP) to Cleanup: Store instances id attribute with other attributes.Dec 1 2021, 5:37 AM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).

Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.

Jacques Lucke (JacquesLucke) accepted this revision.Dec 1 2021, 11:19 AM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/blenkernel/intern/geometry_component_instances.cc
440	`ATTR_DOMAIN_INSTANCE` Otherwise it breaks the spreadsheet.
source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc
22	Adding that seems unnecessary.