Page MenuHome

Fix T93525: Crash with curve/text armature gizmo
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Dec 1 2021, 4:48 PM.

Details

Summary

The problem is that drw_batch_cache_generate_requested_delayed
is called on the object, which uses the original object data type to
choose which data type to get info for. So for curves and text it uses
the incorrect type (not the evaluated mesh like we hardcoded in the
armature overlay code).

To fix this I hardcoded the "delayed" generation to only use the
evaluated mesh. Luckily it wasn't use elsewhere besides this
armature overlay system. That seems like the simplest fix for
3.0, and a proper solution should rewrite this whole area, so
I don't think it introduces much technical debt.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Dec 1 2021, 4:48 PM
Hans Goudey (HooglyBoogly) created this revision.
This revision is now accepted and ready to land.Dec 1 2021, 6:08 PM