Page MenuHome

Geometry Nodes: Use mutable input for the resample curve node
AbandonedPublic

Authored by Hans Goudey (HooglyBoogly) on Dec 1 2021, 7:24 PM.

Details

Reviewers
None
Summary

Pros are avoiding copies of spline attributes, avoiding copies when
only a few splines are selected. Cons are potentially copies when
the input curve has multiple users. The code is also simpler.

I expect using the selection input is pretty rare, but when you
actually only want to resample a few splines, it feels a bit silly
to duplicate the entire curve.

Combined with some CoW behavior when copying CurveEval,
this probably gets us the best of both worlds.

Diff Detail

Repository
rB Blender
Branch
resample-mutable-input (branched from master)
Build Status
Buildable 19131
Build 19131: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Dec 1 2021, 7:24 PM
Hans Goudey (HooglyBoogly) created this revision.

This won't make much sense when we refactor the curve data structure (T95355), unless the splines are resampled with their existing length. I'll abandon it for now since things are changing anyway.